Page MenuHomePhabricator

Reject ambiguous URIs with unescaped "#" or "?" in username/password parts
ClosedPublic

Authored by epriestley on Apr 10 2017, 4:54 PM.
Tags
None
Referenced Files
F17898598: D17647.diff
Tue, Jul 29, 8:13 AM
F17657205: D17647.id42441.diff
Sat, Jul 12, 12:04 PM
Unknown Object (File)
Mon, Jun 30, 3:31 PM
Unknown Object (File)
Jun 18 2025, 1:58 AM
Unknown Object (File)
Jun 18 2025, 1:58 AM
Unknown Object (File)
Jun 16 2025, 10:03 AM
Unknown Object (File)
May 29 2025, 9:15 AM
Unknown Object (File)
May 6 2025, 11:19 PM
Subscribers
None

Details

Summary

Fixes T12526. These URIs are ambiguous and nonstandard, and different versions of different clients parse them differently.

Instead of trying to get this right across PHP versions, just reject these outright. No normal user will ever expect these to work.

Test Plan

Ran unit tests in PHP 7.1, got clean results. See T12526 for more discussion.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable