Subprojects tabs
ClosedPublic
Actions

Authored by epriestley on May 15 2017, 1:38 PM.

Details

Reviewers

Maniphest Tasks

T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them

Commits

rP5fee24fa4311: (stable) Add required needMembers/needWatchers calls to Project…
rP7f54f79fd1c3: Add required needMembers/needWatchers calls to Project Profile/Subprojects tabs

Summary

Fixes T12710. See that task for discussion. This is pretty ugly/redundant but not broken.

(Feel free to reject this and pursue something else.)

Test Plan

For a project with active subprojects/milestones, viewed the project profile and subprojects tabs.
After patch: they're ugly, but no longer fatal.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 15 2017, 1:38 PM

Harbormaster completed remote builds in B16935: Diff 43010.May 15 2017, 1:39 PM

Ah sorry, milestone and subprojects are on this morning's agenda to clean up.

This revision is now accepted and ready to land.May 15 2017, 1:43 PM

🐱

Closed by commit rP7f54f79fd1c3: Add required needMembers/needWatchers calls to Project Profile/Subprojects tabs (authored by epriestley, committed by epriestley). · Explain WhyMay 15 2017, 1:44 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D17883: Restrict watching and member project display better.May 15 2017, 4:00 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectProfileController.php

2 lines

PhabricatorProjectSubprojectsController.php

4 lines

Diff 43011

View Options

src/applications/project/controller/PhabricatorProjectProfileController.php