Add Member/Watcher info to search results
ClosedPublic
Actions

Authored by chad on May 15 2017, 12:35 AM.

Details

Reviewers

Maniphest Tasks

T12707: Add "watching" to Project ApplicationSearch

Commits

rP40228c56a9b7: (stable) Add Member/Watcher info to search results
rPa5ad11d2d2f1: Add Member/Watcher info to search results

Summary

Fixes T12707 Adds additional information to search results for if user is a member or a watcher of a project. Also removed the icon colors, which I'll find a better way to denote in future.

Test Plan

Join a project, watch a project, view results list in /projects/

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.May 15 2017, 12:35 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 15 2017, 12:35 AM

Removing the colors without replacement seems sketchy given that we let you search for them, but maybe no one will notice.

This revision is now accepted and ready to land.May 15 2017, 12:36 AM

Harbormaster completed remote builds in B16931: Diff 43007.May 15 2017, 12:36 AM

probably going to make cards that render the project, then re-use as hovercards

I will donate $5 to Phacility if someone files a bug report before I fix.

Closed by commit rPa5ad11d2d2f1: Add Member/Watcher info to search results (authored by chad, committed by chad). · Explain WhyMay 15 2017, 12:38 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12710: Project "Profile" and "Subproject" tabs now require members/watchers, but do not load them.May 15 2017, 1:35 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

query/

PhabricatorProjectSearchEngine.php

4 lines

view/

PhabricatorProjectListView.php

16 lines

Diff 43008

View Options

src/applications/project/query/PhabricatorProjectSearchEngine.php