Page MenuHomePhabricator
Differential D17558

Allow users to resign if they have authority over any reviewer
ClosedPublic
Actions

Authored by epriestley on Mar 24 2017, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 1:01 AM
Unknown Object (File)
Mon, Dec 9, 12:45 PM
Unknown Object (File)
Mon, Dec 9, 12:45 PM
Unknown Object (File)
Mon, Dec 9, 12:45 PM
Unknown Object (File)
Thu, Dec 5, 11:21 AM
Unknown Object (File)
Thu, Dec 5, 7:58 AM
Unknown Object (File)
Wed, Dec 4, 12:44 AM
Unknown Object (File)
Fri, Nov 29, 5:13 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11050: Allow resigning from a review you are not directly responsible for
T12446: Can't create new diffs using `arc diff` after upgrade (possibly related to 0ceab7d36f914f1c7ae45b733a1ab1ae7b7afbad)
Commits
rP24b6c7d7186a: Allow users to resign if they have authority over any reviewer
Summary

Ref T11050. The old rule was "you can only resign if you're a reviewer".

With the new behavior of "resign", the rule should be "you can resign if you're a reviewer, or you have authority over any reviewer". Make it so.

Also fixes T12446. I don't know how to reproduce that but I'm pretty sure this'll fix it?

Test Plan
  • Could not resign from a revision with no authority/reviewer.
  • Resigned from a revision with myself as a reviewer.
  • Resigned from a revision with a package I owned as a reviewer.
  • Could not resign from a revision I had already resigned from.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 42227

View Options

src/applications/differential/xaction/DifferentialRevisionResignTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionTransactionType.php

Loading...
Phabricator · Built by Phacility