Page MenuHomePhabricator

Allow users to resign if they have authority over any reviewer
ClosedPublic

Authored by epriestley on Mar 24 2017, 8:07 PM.

Details

Summary

Ref T11050. The old rule was "you can only resign if you're a reviewer".

With the new behavior of "resign", the rule should be "you can resign if you're a reviewer, or you have authority over any reviewer". Make it so.

Also fixes T12446. I don't know how to reproduce that but I'm pretty sure this'll fix it?

Test Plan
  • Could not resign from a revision with no authority/reviewer.
  • Resigned from a revision with myself as a reviewer.
  • Resigned from a revision with a package I owned as a reviewer.
  • Could not resign from a revision I had already resigned from.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 24 2017, 8:07 PM
chad accepted this revision.Mar 24 2017, 8:09 PM
This revision is now accepted and ready to land.Mar 24 2017, 8:09 PM
This revision was automatically updated to reflect the committed changes.