Page MenuHomePhabricator

Allow users to resign if they have authority over any reviewer
ClosedPublic

Authored by epriestley on Mar 24 2017, 8:07 PM.
Tags
None
Referenced Files
F15444436: D17558.id.diff
Thu, Mar 27, 9:36 AM
F15440597: D17558.diff
Wed, Mar 26, 1:42 PM
F15428975: D17558.id42227.diff
Sun, Mar 23, 11:50 PM
F15392001: D17558.id42227.diff
Sat, Mar 15, 12:47 PM
Unknown Object (File)
Feb 9 2025, 3:34 AM
Unknown Object (File)
Feb 9 2025, 3:34 AM
Unknown Object (File)
Feb 9 2025, 3:34 AM
Unknown Object (File)
Jan 28 2025, 2:21 AM
Subscribers
None

Details

Summary

Ref T11050. The old rule was "you can only resign if you're a reviewer".

With the new behavior of "resign", the rule should be "you can resign if you're a reviewer, or you have authority over any reviewer". Make it so.

Also fixes T12446. I don't know how to reproduce that but I'm pretty sure this'll fix it?

Test Plan
  • Could not resign from a revision with no authority/reviewer.
  • Resigned from a revision with myself as a reviewer.
  • Resigned from a revision with a package I owned as a reviewer.
  • Could not resign from a revision I had already resigned from.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable