Page MenuHomePhabricator
Differential D17558

Allow users to resign if they have authority over any reviewer
ClosedPublic
Actions

Authored by epriestley on Mar 24 2017, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:21 AM
Unknown Object (File)
Fri, Apr 19, 11:15 PM
Unknown Object (File)
Tue, Apr 9, 2:36 AM
Unknown Object (File)
Mon, Apr 8, 9:33 PM
Unknown Object (File)
Mon, Apr 1, 2:49 PM
Unknown Object (File)
Sun, Mar 31, 3:49 PM
Unknown Object (File)
Thu, Mar 28, 11:10 AM
Unknown Object (File)
Mar 27 2024, 6:32 AM
View All 83 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11050: Allow resigning from a review you are not directly responsible for
T12446: Can't create new diffs using `arc diff` after upgrade (possibly related to 0ceab7d36f914f1c7ae45b733a1ab1ae7b7afbad)
Commits
rP24b6c7d7186a: Allow users to resign if they have authority over any reviewer
Summary

Ref T11050. The old rule was "you can only resign if you're a reviewer".

With the new behavior of "resign", the rule should be "you can resign if you're a reviewer, or you have authority over any reviewer". Make it so.

Also fixes T12446. I don't know how to reproduce that but I'm pretty sure this'll fix it?

Test Plan
  • Could not resign from a revision with no authority/reviewer.
  • Resigned from a revision with myself as a reviewer.
  • Resigned from a revision with a package I owned as a reviewer.
  • Could not resign from a revision I had already resigned from.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 42227

View Options

src/applications/differential/xaction/DifferentialRevisionResignTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionTransactionType.php

Loading...
Phabricator · Built by Phacility