Page MenuHomePhabricator

Allow users to resign if they have authority over any reviewer
ClosedPublic

Authored by epriestley on Mar 24 2017, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 2, 9:10 PM
Unknown Object (File)
Mon, Jun 2, 2:13 AM
Unknown Object (File)
Thu, May 29, 8:44 AM
Unknown Object (File)
Wed, May 28, 1:20 PM
Unknown Object (File)
May 8 2025, 11:42 PM
Unknown Object (File)
May 1 2025, 11:57 PM
Unknown Object (File)
Apr 26 2025, 1:07 PM
Unknown Object (File)
Apr 11 2025, 1:15 PM
Subscribers
None

Details

Summary

Ref T11050. The old rule was "you can only resign if you're a reviewer".

With the new behavior of "resign", the rule should be "you can resign if you're a reviewer, or you have authority over any reviewer". Make it so.

Also fixes T12446. I don't know how to reproduce that but I'm pretty sure this'll fix it?

Test Plan
  • Could not resign from a revision with no authority/reviewer.
  • Resigned from a revision with myself as a reviewer.
  • Resigned from a revision with a package I owned as a reviewer.
  • Could not resign from a revision I had already resigned from.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable