Page MenuHomePhabricator

Allow users to resign if they have authority over any reviewer
ClosedPublic

Authored by epriestley on Mar 24 2017, 8:07 PM.
Tags
None
Referenced Files
F17972534: D17558.diff
Fri, Aug 1, 3:41 PM
F17843841: D17558.id42227.diff
Sun, Jul 27, 1:25 AM
F17819582: D17558.diff
Sat, Jul 26, 1:20 AM
Unknown Object (File)
Jul 1 2025, 10:11 PM
Unknown Object (File)
Jun 30 2025, 1:48 PM
Unknown Object (File)
Jun 28 2025, 9:45 PM
Unknown Object (File)
Jun 2 2025, 9:10 PM
Unknown Object (File)
Jun 2 2025, 2:13 AM
Subscribers
None

Details

Summary

Ref T11050. The old rule was "you can only resign if you're a reviewer".

With the new behavior of "resign", the rule should be "you can resign if you're a reviewer, or you have authority over any reviewer". Make it so.

Also fixes T12446. I don't know how to reproduce that but I'm pretty sure this'll fix it?

Test Plan
  • Could not resign from a revision with no authority/reviewer.
  • Resigned from a revision with myself as a reviewer.
  • Resigned from a revision with a package I owned as a reviewer.
  • Could not resign from a revision I had already resigned from.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable