Page MenuHomePhabricator

Highlight strong tag in document headers
ClosedPublic

Authored by chad on Mar 6 2017, 3:58 PM.
Tags
None
Referenced Files
F12838300: D17469.diff
Thu, Mar 28, 6:04 PM
Unknown Object (File)
Tue, Mar 5, 6:51 AM
Unknown Object (File)
Jan 25 2024, 8:29 AM
Unknown Object (File)
Jan 25 2024, 12:42 AM
Unknown Object (File)
Jan 23 2024, 1:43 AM
Unknown Object (File)
Jan 20 2024, 10:55 AM
Unknown Object (File)
Jan 18 2024, 2:13 PM
Unknown Object (File)
Jan 12 2024, 8:58 AM
Subscribers

Details

Summary

Fixes T12357. Adds some color to highlighted text in headers.

Test Plan

Header with strong copy

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Maybe try text shadow or text outline (or "font-weight: 90000-super-bold" if that works) or something instead?

  • This communicates information only through use of color.
  • I think we use the "fire" color for dead wiki links already: xxxx; conflating these seems a little confusing.
  • Text shadow feels more "bold-like" to me (making the glyph shapes heavier) than a coloration change.
This revision is now accepted and ready to land.Mar 6 2017, 5:18 PM
This revision was automatically updated to reflect the committed changes.