Put revisions waiting on other reviewers in their own bucket
ClosedPublic
Actions

Authored by epriestley on Feb 27 2017, 6:17 PM.

Tags

None

Referenced Files

	F19569597: D17425.diff
	Sun, Feb 1, 12:07 AM

	F19515435: D17425.diff
	Wed, Jan 14, 11:31 AM

	F19515421: D17425.diff
	Wed, Jan 14, 11:18 AM

	F19515405: D17425.diff
	Wed, Jan 14, 11:05 AM

	F19303878: D17425.diff
	Dec 24 2025, 6:07 AM

	F18872951: D17425.id41900.diff
	Nov 5 2025, 7:07 AM

	F18850810: D17425.id41900.diff
	Oct 30 2025, 7:33 PM

	F18843174: D17425.id41903.diff
	Oct 28 2025, 9:06 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12323: Revisions show in Other Revisions when acceptance status is unclear

Commits

rP6c21646b5f33: Put revisions waiting on other reviewers in their own bucket

Summary

Fixes T12323. See that task for discussion.

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 27 2017, 6:17 PM

chad accepted this revision.Feb 27 2017, 6:18 PM

This revision is now accepted and ready to land.Feb 27 2017, 6:18 PM

Harbormaster completed remote builds in B15801: Diff 41900.Feb 27 2017, 6:18 PM

Closed by commit rP6c21646b5f33: Put revisions waiting on other reviewers in their own bucket (authored by epriestley, committed by epriestley). · Explain WhyFeb 27 2017, 6:47 PM

This revision was automatically updated to reflect the committed changes.

jcarrillo7 mentioned this in T12235: Differential wrongly says I "Must Review" reviews rejected by group.Mar 1 2017, 12:27 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionRequiredActionResultBucket.php

26 lines

Diff 41903

View Options

src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php

Put revisions waiting on other reviewers in their own bucketClosedPublicActions