Don't try to access the Stripe object until the user submits the credit card form
ClosedPublic
Actions

Authored by epriestley on Feb 10 2017, 4:35 PM.

Tags

None

Referenced Files

	F18825685: D17333.diff
	Thu, Oct 23, 11:32 PM

	F18791135: D17333.id.diff
	Thu, Oct 16, 3:44 AM

	F18784456: D17333.id41688.diff
	Mon, Oct 13, 12:34 PM

	F18733462: D17333.id.diff
	Tue, Sep 30, 10:35 PM

	F18670508: D17333.diff
	Thu, Sep 25, 12:31 AM

	F18623227: D17333.id.diff
	Sep 15 2025, 2:53 PM

	F18616360: D17333.diff
	Sep 14 2025, 5:15 PM

	F18508502: D17333.id.diff
	Sep 5 2025, 2:51 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12232: Phortune "add payment method" erroring out on submission

Commits

rP4039f5f11b71: Don't try to access the Stripe object until the user submits the credit card…

Summary

Ref T12232. I can't reproduce the original issue, but this should probably fix it without side effects?

Test Plan

Added a card with Stripe, but I could do that before too.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 10 2017, 4:35 PM

chad accepted this revision.Feb 10 2017, 4:35 PM

This revision is now accepted and ready to land.Feb 10 2017, 4:35 PM

Closed by commit rP4039f5f11b71: Don't try to access the Stripe object until the user submits the credit card… (authored by epriestley, committed by epriestley). · Explain WhyFeb 10 2017, 4:40 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12232: Phortune "add payment method" erroring out on submission.Feb 10 2017, 4:44 PM

epriestley mentioned this in T12307: Users unable to add new credit cards to Autopay?.Feb 22 2017, 12:41 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

14 lines

webroot/

rsrc/

js/

application/

phortune/

behavior-stripe-payment-form.js

3 lines

Diff 41688

View Options

resources/celerity/map.php