Page MenuHomePhabricator
Differential D16967

Let PhutilTypeLexer support qualified names
ClosedPublic
Actions

Authored by wjiang on Dec 1 2016, 1:05 AM.
Tags
None
Referenced Files
F14142669: D16967.id.diff
Tue, Dec 3, 1:39 PM
Unknown Object (File)
Wed, Nov 27, 4:00 AM
Unknown Object (File)
Tue, Nov 26, 11:57 AM
Unknown Object (File)
Mon, Nov 25, 5:15 AM
Unknown Object (File)
Sat, Nov 23, 1:47 PM
Unknown Object (File)
Thu, Nov 21, 9:54 PM
Unknown Object (File)
Tue, Nov 19, 3:05 PM
Unknown Object (File)
Fri, Nov 15, 5:05 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
joshuaspence
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T11933: Let `PhutilTypeLexer` support PHP style qualified names
Commits
rPHUde65ac554ca3: Let PhutilTypeLexer support qualified names
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Ref T11933. This lets PhutilTypeLexer support qualified names.

Test Plan

Unit test

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wjiang updated this revision to Diff 40832.Dec 1 2016, 1:05 AM
wjiang retitled this revision from to Let PhutilTypeLexer support qualified names.
wjiang updated this object.
wjiang edited the test plan for this revision. (Show Details)
wjiang added a reviewer: joshuaspence.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 1 2016, 1:05 AM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added a subscriber: epriestley. · View Herald Transcript
wjiang updated this object.Dec 1 2016, 1:06 AM
wjiang edited edge metadata.
wjiang added a task: T11933: Let `PhutilTypeLexer` support PHP style qualified names.
epriestley requested changes to this revision.Dec 1 2016, 1:15 AM
epriestley added a reviewer: epriestley.

This change is fine, but I think the new expression is too permissive. Let's add these "good" test cases:

\SomeClass
\Namespace\SomeClass
A\B\C
\A\B\C

And these "bad" test cases:

\
\\
\SomeClass\
SomeClass\

I think some of those won't pass; adjust the regular expression until they do.

(I think all those bad cases are actually illegal, but I haven't used namespaces in PHP very much so my understanding of the syntax may be incorrect.)

This revision now requires changes to proceed.Dec 1 2016, 1:15 AM
wjiang updated this revision to Diff 40833.Dec 1 2016, 1:46 AM
wjiang edited edge metadata.
  • Add more tests and fix regex
Herald added a subscriber: Korvin. · View Herald TranscriptDec 1 2016, 1:46 AM
wjiang updated this revision to Diff 40834.Dec 1 2016, 1:48 AM
wjiang edited edge metadata.
  • fix tests
epriestley accepted this revision.Dec 1 2016, 1:50 AM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Dec 1 2016, 1:50 AM
Closed by commit rPHUde65ac554ca3: Let PhutilTypeLexer support qualified names (authored by wjiang, committed by epriestley). · Explain WhyDec 1 2016, 1:50 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11933: Let `PhutilTypeLexer` support PHP style qualified names.Dec 1 2016, 7:20 PM

Revision Contents
Changeset List

PathSize
src/
lexer/
2 lines
parser/
__tests__/
8 lines

Diff 40835

View Options

src/lexer/PhutilTypeLexer.php

Loading...
View Options

src/parser/__tests__/PhutilTypeSpecTestCase.php

Loading...
Phabricator · Built by Phacility