Page MenuHomePhabricator
Differential D16872

Document calendar summary icons
ClosedPublic
Actions

Authored by epriestley on Nov 15 2016, 8:46 PM.
Tags
None
Referenced Files
F14032041: D16872.id40625.diff
Sat, Nov 9, 12:38 PM
F14032040: D16872.id40622.diff
Sat, Nov 9, 12:38 PM
F14032039: D16872.id.diff
Sat, Nov 9, 12:38 PM
F14019776: D16872.diff
Tue, Nov 5, 11:38 PM
F14007090: D16872.diff
Mon, Oct 28, 11:24 PM
F14002787: D16872.id.diff
Fri, Oct 25, 10:29 PM
F13987498: D16872.diff
Mon, Oct 21, 9:46 AM
F13986730: D16872.id40625.diff
Mon, Oct 21, 5:06 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11809: Calendar v1 Errata Mark II
Commits
rPc7f2e4a9246e: Document calendar summary icons
Summary

Fixes T11809. Ref

  • Explicitly document the summary icon hints -- I don't think these are too hard to figure out (and maybe this stuff should just go in the tooltips) but we can start here.
  • Use color + shape to distinguish between "cancelled" and "declined", not just color (for users with vision accessibility issues).
  • Translate a "minute(s)" string into sensible English.
  • Use RSVP status on the month view green circle thing.
Test Plan
  • Read docs.
  • Looked at month view.
  • Read reminder mail.
  • Viewed month view mobile view.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40622.Nov 15 2016, 8:46 PM
epriestley retitled this revision from to Document calendar summary icons.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11809: Calendar v1 Errata Mark II.
chad accepted this revision.Nov 15 2016, 9:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 15 2016, 9:36 PM
Closed by commit rPc7f2e4a9246e: Document calendar summary icons (authored by epriestley, committed by epriestley). · Explain WhyNov 15 2016, 9:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
query/
4 lines
storage/
12 lines
people/
controller/
3 lines
docs/
user/
userguide/
16 lines
infrastructure/
internationalization/
translation/
8 lines

Diff 40625

View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
View Options

src/docs/user/userguide/calendar.diviner

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility