Paths

Table of Contentst

Differential D16819

On `@username` mentions in remarkup, show the "busy" dot color
ClosedPublic
Actions

Authored by epriestley on Nov 7 2016, 8:26 PM.

Details

Reviewers

chad

Maniphest Tasks

T11809: Calendar v1 Errata Mark II

Commits

rP6a7dde03ccfb: On `@username` mentions in remarkup, show the "busy" dot color

Summary

Ref T11809. I missed this when adding a "Busy" status.

Also the other dot is orange? Just make them all orange for consistency.

Test Plan

Viewed @username of busy users (orange), away users (red).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40499.Nov 7 2016, 8:26 PM

epriestley retitled this revision from to On `@username` mentions in remarkup, show the "busy" dot color.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11809: Calendar v1 Errata Mark II.

epriestley mentioned this in T11816: Calendar: Feedback and Suggestions.Nov 7 2016, 8:40 PM

the image dot looks like ass.

chad accepted this revision.Nov 7 2016, 8:50 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 7 2016, 8:50 PM

if only you could draw a circle in CSS

Computers just can't do that.

I cheat with font-awesome

that's a circle you can set your watch to.

Closed by commit rP6a7dde03ccfb: On `@username` mentions in remarkup, show the "busy" dot color (authored by epriestley, committed by epriestley). · Explain WhyNov 7 2016, 10:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

storage/

PhabricatorCalendarEventInvitee.php

2 lines

people/

markup/

PhabricatorMentionRemarkupRule.php

7 lines

Diff 40502

View Options

src/applications/calendar/storage/PhabricatorCalendarEventInvitee.php