Page MenuHomePhabricator

Smooth out various transaction/editing behaviors for Calendar
ClosedPublic

Authored by epriestley on Nov 2 2016, 10:43 PM.
Tags
None
Referenced Files
F13050423: D16796.id40452.diff
Fri, Apr 19, 2:53 AM
Unknown Object (File)
Thu, Apr 11, 10:11 AM
Unknown Object (File)
Mon, Apr 8, 1:44 AM
Unknown Object (File)
Fri, Apr 5, 6:45 AM
Unknown Object (File)
Tue, Apr 2, 5:45 AM
Unknown Object (File)
Mar 13 2024, 6:25 PM
Unknown Object (File)
Mar 11 2024, 8:03 PM
Unknown Object (File)
Jan 25 2024, 11:11 AM
Subscribers
None

Details

Summary

Ref T11809.

  • Allow users to remove the "Until" date from recurring events.
  • When removing "Until", show a sensible string ("...set this event to repeat forever.")
  • When users go through the "Make Recurring" workflow, don't require them to explicitly select "Recurring: Recurring" from the dropdown. This intent is clear from clicking "Make Recurring".
  • When editing "All Future Events", don't literally apply date changes to them, since that doesn't make sense. We update the template, then reschedule any events which haven't been edited already. I think this is what users probably mean if they make this edit.
  • When creating an event with a non-default icon, don't show "alice changed the icon from Default to Party.".
  • Hide the "recurring mode" transaction, which had no string ("alice edited this Event.") and was redundant anyway.
  • Also, add a little piece of developer text to make hunting these things down easier.
Test Plan

Edited various events, parents, children, made events recur, set until, unset until, viewed transactions, rescheduled parents, rescheduled children.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Smooth out various transaction/editing behaviors for Calendar.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 3 2016, 3:09 AM
This revision was automatically updated to reflect the committed changes.