Page MenuHomePhabricator

Fix Herald test adapter for commits
ClosedPublic

Authored by epriestley on Aug 17 2016, 3:37 PM.

Details

Summary

Fixes T11488. I broke this in D16360, I think by doing a little extra refactoring after testing it.

This code is very old, before commits always needed to have repositories attached in order to do policy checks.

Modernize it by mostly just using the repository which is present on the Commit object, and using the existing edge cache.

Test Plan

Ran a commit through the Herald test adapter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable