Page MenuHomePhabricator

Show error message in Diffusion if branch is not tracked
AbandonedPublic

Authored by epriestley on Aug 17 2017, 4:34 PM.

Details

Summary

Fixes T10964. This check if a branch is being tracked before deciding to show information. This feels a little janky, but works OK.

Test Plan

Set Track Only to stable, with master set to default.

Diff Detail

Repository
rP Phabricator
Branch
untracked (branched from master)
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 18097
Build 24317: Run Core Tests
Build 24316: arc lint + arc unit

Event Timeline

chad created this revision.Aug 17 2017, 4:34 PM
chad edited the test plan for this revision. (Show Details)Aug 17 2017, 4:34 PM
chad added inline comments.Aug 17 2017, 4:41 PM
src/applications/diffusion/controller/DiffusionRepositoryController.php
63

I think this if statement is never hit. Unsure what the intent of the task was, maybe this case is not possible.

Can you cover these cases in your test plan?

  • Create a new repository, immediately set it to track only stable before activating it, activate it, view main page.
  • View a branch which does not exist, and is tracked.
  • View a branch which does not exist, and is not tracked.
  • View a branch which exists, and is tracked.
  • Delete a tracked branch, then view it in the web UI.
  • Close a branch in Mercurial, then view it.
chad added a comment.Aug 17 2017, 5:16 PM

Create a new repository, immediately set it to track only stable before activating it, activate it, view main page.

Uhhhhhhhhh

chad added a comment.Aug 17 2017, 5:17 PM

I guess this is more than UI changes.

chad updated this revision to Diff 44303.Aug 17 2017, 5:30 PM
  • just pushing changes, then abandoning
chad abandoned this revision.Aug 17 2017, 5:31 PM
chad updated this revision to Diff 44305.Aug 17 2017, 5:51 PM
  • better test cases?
chad planned changes to this revision.Aug 17 2017, 6:19 PM
chad updated this revision to Diff 44306.Aug 17 2017, 6:24 PM
  • I think this is all correct, but some outlier bugs in HG and shouldTrack are tripping me up
epriestley commandeered this revision.Mon, Apr 15, 5:12 PM
epriestley abandoned this revision.
epriestley edited reviewers, added: chad; removed: epriestley.

Mooted by context changes in T10964.