Page MenuHomePhabricator
Create Task
Maniphest T10759

Run PhabricatorDatabase/MySQLSetupCheck against all configured replicas
Closed, ResolvedPublic
Actions

Description

Currently, PhabricatorMySQLSetupCheck runs only on the w mode connection:

  • This fails in read-only mode (shortly worked around).
  • Instead, every replica should be checked individually.

More fundamentally PhabricatorDatabaseSetupCheck runs explicitly against only the non-cluster connection.

  • This fails to detect total failure of cluster configuration.
  • Instead, it should be aware of cluster configuration.

Revisions and Commits

rP Phabricator
D16905rPbcfd515b320d Run all minor setup checks on all configured database hosts
D16904rP326d5bf8004e Detect replicating masters and fatal (also, warn on nonreplicating replicas)
D16903rPbc4187d70949 When we "discover" new fatal setup issues, stop serving traffic
D16902rP78040e0ff577 Run "DatabaseSetup" checks against all configured hosts
D15668rP6a4a9bb2d284 When `cluster.databases` is configured, read the master connection from it

Related Objects
Search...

Event Timeline

epriestley created this task.Apr 9 2016, 12:56 PM
epriestley created this object with edit policy "All Users".
epriestley changed the edit policy from "All Users" to "Community (Project)".
eadler added a project: Restricted Project.Apr 9 2016, 5:59 PM
Herald added a subscriber: eadler. · View Herald TranscriptApr 9 2016, 5:59 PM
epriestley renamed this task from Run PhabricatorMySQLSetupCheck against all configured replicas to Run PhabricatorDatabase/MySQLSetupCheck against all configured replicas.Apr 10 2016, 2:46 AM
epriestley updated the task description. (Show Details)
epriestley added a revision: D15668: When `cluster.databases` is configured, read the master connection from it.Apr 10 2016, 3:33 AM
epriestley added a commit: rP6a4a9bb2d284: When `cluster.databases` is configured, read the master connection from it.Apr 10 2016, 7:18 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 17 2016, 6:25 PM
epriestley added a parent task: T11044: Support partitioning application databases across multiple database hosts.Jun 16 2016, 12:30 PM

T11044 makes this both more relevant and somewhat easier.

epriestley mentioned this in T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.Sep 5 2016, 4:36 PM
epriestley mentioned this in T11044: Support partitioning application databases across multiple database hosts.Nov 19 2016, 10:11 PM
epriestley added a revision: D16902: Run "DatabaseSetup" checks against all configured hosts.Nov 21 2016, 1:39 PM
epriestley added a revision: D16903: When we "discover" new fatal setup issues, stop serving traffic.Nov 21 2016, 2:51 PM
epriestley added a revision: D16904: Detect replicating masters and fatal (also, warn on nonreplicating replicas).Nov 21 2016, 3:59 PM
epriestley added a revision: D16905: Run all minor setup checks on all configured database hosts.Nov 21 2016, 5:10 PM
epriestley added a commit: rP78040e0ff577: Run "DatabaseSetup" checks against all configured hosts.Nov 21 2016, 11:49 PM
epriestley closed this task as Resolved by committing rPbcfd515b320d: Run all minor setup checks on all configured database hosts.Nov 21 2016, 11:54 PM
epriestley added a commit: rPbc4187d70949: When we "discover" new fatal setup issues, stop serving traffic.
epriestley added a commit: rP326d5bf8004e: Detect replicating masters and fatal (also, warn on nonreplicating replicas).
epriestley added a commit: rPbcfd515b320d: Run all minor setup checks on all configured database hosts.
Phabricator · Built by Phacility