Page MenuHomePhabricator

When `cluster.databases` is configured, read the master connection from it

Authored by epriestley on Apr 10 2016, 3:33 AM.
Referenced Files
Unknown Object (File)
Fri, Aug 5, 9:23 AM
Unknown Object (File)
Sat, Jul 30, 5:57 PM
Unknown Object (File)
Sun, Jul 24, 8:15 AM
Unknown Object (File)
Fri, Jul 22, 6:01 AM
Unknown Object (File)
Sat, Jul 16, 9:20 PM
Unknown Object (File)
Jul 1 2022, 3:43 PM
Unknown Object (File)
Jun 25 2022, 11:50 PM
Unknown Object (File)
Jun 24 2022, 11:33 AM



Ref T4571. Ref T10759. Ref T10758. This isn't complete, but gets most of the job done:

  • When cluster.databases is set up, most things ignore now.
  • You can bin/storage upgrade and stuff works.
  • You can browse around in the web UI and stuff works.

There's still a lot of weird tricky stuff to navigate, and this has real no advantages over configuring a single server yet (no automatic failover, etc).

Test Plan
  • Configured cluster.databases to point at my t1.micro hosts in EC2 (master + replica).
  • Ran bin/storage upgrade, got a new install setup on them properly.
  • Survived setup warnings, browsed around.
  • Switched back to local config, ran bin/storage upgrade, browsed around, went through setup checks.
  • Intentionally broke config (bad hosts, no masters) and things seemed to react reasonably well.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When `cluster.databases` is configured, read the master connection from it.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 10 2016, 3:40 AM
This revision was automatically updated to reflect the committed changes.