Page MenuHomePhabricator

Detect replicating masters and fatal (also, warn on nonreplicating replicas)
ClosedPublic

Authored by epriestley on Nov 21 2016, 3:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 3:58 AM
Unknown Object (File)
Thu, Mar 28, 3:01 AM
Unknown Object (File)
Thu, Mar 28, 3:01 AM
Unknown Object (File)
Fri, Mar 1, 6:48 PM
Unknown Object (File)
Feb 27 2024, 7:07 PM
Unknown Object (File)
Feb 27 2024, 7:07 PM
Unknown Object (File)
Feb 27 2024, 7:07 PM
Unknown Object (File)
Feb 20 2024, 8:28 PM
Subscribers
None

Details

Summary

Ref T10759. Check master/replica status during startup.

After D16903, this also means that we check this status after a database comes back online after being unreachable.

If a master is replicating, fatal (since this can do a million kinds of bad things).

If a replica is not replicating, warn (this just means the replica is behind so some data is at risk).

Also: if your masters were actually configured properly (mine weren't until this change detected it), we would throw away patches as we applied them, so they would only apply to the first master. Instead, properly apply all migration patches to all masters.

Test Plan
  • Started Phabricator with a replicating master, got a fatal.
  • Stopped replication on a replica, got a warning.
  • With two non-replicating masters, upgraded storage.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Detect replicating masters and fatal (also, warn on nonreplicating replicas).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 21 2016, 4:53 PM
This revision was automatically updated to reflect the committed changes.