Run all minor setup checks on all configured database hosts
ClosedPublic
Actions

Authored by epriestley on Nov 21 2016, 5:10 PM.

Details

Reviewers

Maniphest Tasks

T10759: Run PhabricatorDatabase/MySQLSetupCheck against all configured replicas
T11817: Configuration issue MySQL max allowed packet does not mention preferred value

Commits

rPbcfd515b320d: Run all minor setup checks on all configured database hosts

Summary

Fixes T10759. Fixes T11817. This runs all the general sanity/configuration checks on all the active servers.

None of these warnings are very important, and this doesn't change any logical stuff.

Depends on D16904.

Test Plan

Painstakingly triggered each warning, verified that they rendered correctly and that messages told me which host was affected.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40694.Nov 21 2016, 5:10 PM

epriestley retitled this revision from to Run all minor setup checks on all configured database hosts.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T11817: Configuration issue MySQL max allowed packet does not mention preferred value, T10759: Run PhabricatorDatabase/MySQLSetupCheck against all configured replicas.

chad accepted this revision.Nov 21 2016, 5:11 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 21 2016, 5:11 PM

epriestley mentioned this in T11817: Configuration issue MySQL max allowed packet does not mention preferred value.Nov 21 2016, 5:13 PM

epriestley updated this object.Nov 21 2016, 7:56 PM

epriestley edited edge metadata.

epriestley added a parent revision: D16904: Detect replicating masters and fatal (also, warn on nonreplicating replicas).

Closed by commit rPbcfd515b320d: Run all minor setup checks on all configured database hosts (authored by epriestley, committed by epriestley). · Explain WhyNov 21 2016, 11:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorMySQLSetupCheck.php

145 lines

issue/

PhabricatorSetupIssue.php

10 lines

view/

PhabricatorSetupIssueView.php

20 lines

infrastructure/

cluster/

PhabricatorDatabaseRef.php

13 lines

Diff 40703

View Options

src/applications/config/check/PhabricatorMySQLSetupCheck.php

View Options

src/applications/config/issue/PhabricatorSetupIssue.php

View Options

src/applications/config/view/PhabricatorSetupIssueView.php

View Options

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Run all minor setup checks on all configured database hostsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40703

src/applications/config/check/PhabricatorMySQLSetupCheck.php

src/applications/config/issue/PhabricatorSetupIssue.php

src/applications/config/view/PhabricatorSetupIssueView.php

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Run all minor setup checks on all configured database hosts
ClosedPublic
Actions

Revision Contents
Changeset List