Page MenuHomePhabricator

Don't publish anything for "Disable Mail" / "Enable Mail" on projects
ClosedPublic

Authored by epriestley on Feb 29 2016, 12:31 AM.
Tags
None
Referenced Files
F13197283: D15361.id.diff
Mon, May 13, 12:00 AM
Unknown Object (File)
Tue, May 7, 5:25 PM
Unknown Object (File)
Mon, May 6, 7:37 PM
Unknown Object (File)
Apr 12 2024, 1:41 AM
Unknown Object (File)
Apr 8 2024, 11:28 AM
Unknown Object (File)
Mar 5 2024, 9:25 AM
Unknown Object (File)
Mar 5 2024, 9:25 AM
Unknown Object (File)
Mar 5 2024, 9:25 AM
Subscribers
None

Details

Summary

Fixes T10466. Currently, clicking "Disable Mail" or "Enable Mail" on a project toggles an edge, but it gets a default "added an edge" story and transaction record.

These are confusing, useless and not interesting, so just hide them.

Test Plan
  • Before patch: clicked enable/disable mail, saw "added an edge" / "removed an edge" stories in feed and project history.
  • After patch: clicked enable/disable mail, saw nothing in feed or project history.
  • (Note that this patch is not retroactive for feed, so already-published stories won't unpublish.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't publish anything for "Disable Mail" / "Enable Mail" on projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 29 2016, 12:32 AM
This revision was automatically updated to reflect the committed changes.