Differential D15361

Don't publish anything for "Disable Mail" / "Enable Mail" on projects
ClosedPublic
Actions

Authored by epriestley on Feb 29 2016, 12:31 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 1:26 AM

	Unknown Object (File)
	Wed, Dec 18, 1:26 AM

	Unknown Object (File)
	Sun, Dec 15, 7:42 PM

	Unknown Object (File)
	Tue, Dec 10, 3:00 PM

	Unknown Object (File)
	Mon, Dec 9, 10:48 PM

	Unknown Object (File)
	Mon, Dec 9, 4:39 PM

	Unknown Object (File)
	Sat, Dec 7, 12:57 AM

	Unknown Object (File)
	Fri, Dec 6, 4:00 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10466: Wrong mail and extra feed story when joining a project

Commits

Restricted Diffusion Commit
rP2e19b78b8dd6: Don't publish anything for "Disable Mail" / "Enable Mail" on projects

Summary

Fixes T10466. Currently, clicking "Disable Mail" or "Enable Mail" on a project toggles an edge, but it gets a default "added an edge" story and transaction record.

These are confusing, useless and not interesting, so just hide them.

Test Plan

Before patch: clicked enable/disable mail, saw "added an edge" / "removed an edge" stories in feed and project history.
After patch: clicked enable/disable mail, saw nothing in feed or project history.
(Note that this patch is not retroactive for feed, so already-published stories won't unpublish.)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37038.Feb 29 2016, 12:31 AM

epriestley retitled this revision from to Don't publish anything for "Disable Mail" / "Enable Mail" on projects.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10466: Wrong mail and extra feed story when joining a project.

chad accepted this revision.Feb 29 2016, 12:32 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 29 2016, 12:32 AM

Closed by commit rP2e19b78b8dd6: Don't publish anything for "Disable Mail" / "Enable Mail" on projects (authored by epriestley, committed by epriestley). · Explain WhyFeb 29 2016, 12:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

storage/

PhabricatorProjectTransaction.php

15 lines

Diff 37039

src/applications/project/storage/PhabricatorProjectTransaction.php

Loading...