Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T5655: Standardize naming conventions
- Commits
- rPHU51472fd62263: Rename `PhutilRemarkupRule` subclasses
Not yet tested... this is likely to break external code, so I'm not sure whether or not we want to pursue this.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- renameremarkup
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1809 Build 1810: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I'm not really sure about how PhutilRemarkupEngineBlockRule subclasses should be named.
Comment Actions
I think perhaps PhutilRemarkupEngineRemarkupLiteralBlockRule should really be PhutilLiteralRemarkupRemarkupBlockRule.
Comment Actions
Maybe these should be PhutilRemarkupBoldRule, not PhutilBoldRemarkupRule? That makes the custom rules in D9994 a little easier too.
I think you're right on the literal rule.
| src/markup/engine/remarkup/markuprule/PhutilRemarkupHyperlinkRule.php | ||
|---|---|---|
| 3 | Oh, this probably isn't okay... Should I provide a migration path or is this an outdated TODO? | |
Comment Actions
- Rename classes
- Rename block rules too
- Remove duplicated PhutilRemarkupEngineRemarkupTestInterpreterRule class
| src/markup/engine/remarkup/markuprule/PhutilRemarkupHyperlinkRule.php | ||
|---|---|---|
| 3 | I think it's OK to break Facebook, there is a reasonable pathway for them to stop subclassing this. I'll loop them in on the task. | |