Paths

Table of Contentst

Differential D9994

Rename `PhutilRemarkupRule` subclasses
ClosedPublic
Actions

Authored by joshuaspence on Jul 21 2014, 9:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 13, 12:53 AM

	Unknown Object (File)
	Fri, Jan 3, 1:16 AM

	Unknown Object (File)
	Dec 9 2024, 12:45 AM

	Unknown Object (File)
	Dec 5 2024, 7:09 AM

	Unknown Object (File)
	Dec 4 2024, 8:29 PM

	Unknown Object (File)
	Dec 4 2024, 8:29 PM

	Unknown Object (File)
	Dec 4 2024, 8:07 PM

	Unknown Object (File)
	Dec 4 2024, 4:02 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5655: Standardize naming conventions

Commits

Restricted Diffusion Commit
rPf055736ecad2: Rename `PhutilRemarkupRule` subclasses

Summary

Ref T5655. Depends on D9993.

Test Plan

See D9993.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 24018.Jul 21 2014, 9:47 AM

joshuaspence retitled this revision from to Rename `PhutilRemarkupRule` subclasses.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5655: Standardize naming conventions.

joshuaspence added a parent revision: D9993: Rename `PhutilRemarkupRule` subclasses.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 21 2014, 9:47 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1801: Diff 24018.Jul 21 2014, 9:48 AM

I think we should either keep the "Custom" names or provide a migration pathway for them, since a bunch of installs already subclass them. Keeping them seems kind of OK-ish? Like, "Remarkup" is the application and it's a "Custom" type of "BlockRule"?

All the non-extended ones look fine.

This revision now requires changes to proceed.Jul 21 2014, 1:38 PM

Rename PhutilRemarkupBlockInterpreter classes too

Harbormaster completed remote builds in B1821: Diff 24051.Jul 21 2014, 10:25 PM

Rebasing

Harbormaster completed remote builds in B1856: Diff 24094.Jul 23 2014, 12:50 AM

epriestley accepted this revision.Jul 23 2014, 1:08 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 23 2014, 1:08 AM

Closed by commit rPf055736ecad2 (authored by @joshuaspence).

I think this broke my install - told me something about running "arc liberate", but running that didn't fix the issue.

In D9994#22, @klimek wrote:

I think this broke my install - told me something about running "arc liberate", but running that didn't fix the issue.

Ignore me. I thought I had upgraded libphutil, but apparently something went wrong there... :/

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

78 lines

applications/

countdown/

remarkup/

PhabricatorCountdownRemarkupRule.php

2 lines

dashboard/

remarkup/

PhabricatorDashboardRemarkupRule.php

2 lines

differential/

remarkup/

DifferentialRemarkupRule.php

2 lines

diffusion/

conduit/

DiffusionReadmeQueryConduitAPIMethod.php

3 lines

remarkup/

DiffusionCommitRemarkupRule.php

2 lines

DiffusionRepositoryRemarkupRule.php

2 lines

diviner/

application/

PhabricatorDivinerApplication.php

2 lines

controller/

DivinerAtomController.php

2 lines

markup/

DivinerRemarkupRuleSymbol.php

	DivinerSymbolRemarkupRule.php
	DivinerRemarkupRuleSymbol.php

2 lines

doorkeeper/

remarkup/

DoorkeeperRemarkupRule.php

3 lines

files/

application/

PhabricatorFilesApplication.php

2 lines

	markup/
	remarkup/

	PhabricatorEmbedFileRemarkupRule.php
	PhabricatorRemarkupRuleEmbedFile.php

4 lines

remarkup/

PhabricatorRemarkupRuleEmbedFile.php

harbormaster/

remarkup/

HarbormasterRemarkupRule.php

3 lines

herald/

remarkup/

HeraldRemarkupRule.php

3 lines

legalpad/

remarkup/

LegalpadDocumentRemarkupRule.php

3 lines

macro/

application/

PhabricatorMacroApplication.php

2 lines

	markup/
	remarkup/

	PhabricatorIconRemarkupRule.php
	PhabricatorRemarkupRuleIcon.php

3 lines

	PhabricatorImageMacroRemarkupRule.php
	PhabricatorRemarkupRuleImageMacro.php

2 lines

	PhabricatorMemeRemarkupRule.php
	PhabricatorRemarkupRuleMeme.php

2 lines

remarkup/

PhabricatorRemarkupRuleIcon.php

PhabricatorRemarkupRuleImageMacro.php

PhabricatorRemarkupRuleMeme.php

maniphest/

remarkup/

ManiphestRemarkupRule.php

2 lines

passphrase/

remarkup/

PassphraseRemarkupRule.php

3 lines

paste/

remarkup/

PhabricatorPasteRemarkupRule.php

2 lines

people/

application/

PhabricatorPeopleApplication.php

2 lines

	markup/
	remarkup/

	PhabricatorMentionRemarkupRule.php
	PhabricatorRemarkupRuleMention.php

2 lines

remarkup/

PhabricatorRemarkupRuleMention.php

pholio/

remarkup/

PholioRemarkupRule.php

3 lines

phriction/

	markup/
	remarkup/

PhrictionRemarkupRule.php

remarkup/

PhrictionRemarkupRule.php

storage/

PhrictionContent.php

2 lines

ponder/

remarkup/

PonderRemarkupRule.php

3 lines

project/

remarkup/

ProjectRemarkupRule.php

3 lines

slowvote/

remarkup/

SlowvoteRemarkupRule.php

2 lines

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

2 lines

infrastructure/

markup/

PhabricatorMarkupEngine.php

50 lines

interpreter/

PhabricatorRemarkupBlockInterpreterCowsay.php

PhabricatorRemarkupBlockInterpreterFiglet.php

PhabricatorRemarkupBlockInterpreterGraphviz.php

	PhabricatorRemarkupCowsayBlockInterpreter.php
	PhabricatorRemarkupBlockInterpreterCowsay.php

2 lines

	PhabricatorRemarkupFigletBlockInterpreter.php
	PhabricatorRemarkupBlockInterpreterFiglet.php

2 lines

	PhabricatorRemarkupGraphvizBlockInterpreter.php
	PhabricatorRemarkupBlockInterpreterGraphviz.php

4 lines

rule/

	PhabricatorObjectRemarkupRule.php
	PhabricatorRemarkupRuleObject.php

3 lines

PhabricatorRemarkupCustomBlockRule.php

2 lines

PhabricatorRemarkupCustomInlineRule.php

3 lines

PhabricatorRemarkupRuleObject.php

PhabricatorRemarkupRuleYoutube.php

	PhabricatorYoutubeRemarkupRule.php
	PhabricatorRemarkupRuleYoutube.php

2 lines

Diff 24383

src/__phutil_library_map__.php

Loading...

src/applications/countdown/remarkup/PhabricatorCountdownRemarkupRule.php

Loading...

src/applications/dashboard/remarkup/PhabricatorDashboardRemarkupRule.php

Loading...

src/applications/differential/remarkup/DifferentialRemarkupRule.php

Loading...

src/applications/diffusion/conduit/DiffusionReadmeQueryConduitAPIMethod.php

Loading...

src/applications/diffusion/remarkup/DiffusionCommitRemarkupRule.php

Loading...

src/applications/diffusion/remarkup/DiffusionRepositoryRemarkupRule.php

Loading...

src/applications/diviner/application/PhabricatorDivinerApplication.php

Loading...

src/applications/diviner/controller/DivinerAtomController.php

Loading...

src/applications/diviner/markup/DivinerRemarkupRuleSymbol.php

Loading...

src/applications/diviner/markup/DivinerSymbolRemarkupRule.php

Loading...

src/applications/doorkeeper/remarkup/DoorkeeperRemarkupRule.php

Loading...

src/applications/files/application/PhabricatorFilesApplication.php

Loading...

src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php

Loading...

src/applications/files/remarkup/PhabricatorRemarkupRuleEmbedFile.php

Loading...

src/applications/harbormaster/remarkup/HarbormasterRemarkupRule.php

Loading...

src/applications/herald/remarkup/HeraldRemarkupRule.php

Loading...

src/applications/legalpad/remarkup/LegalpadDocumentRemarkupRule.php

Loading...

src/applications/macro/application/PhabricatorMacroApplication.php

Loading...

src/applications/macro/markup/PhabricatorIconRemarkupRule.php

Loading...

src/applications/macro/markup/PhabricatorImageMacroRemarkupRule.php

Loading...

src/applications/macro/markup/PhabricatorMemeRemarkupRule.php

Loading...

src/applications/macro/remarkup/PhabricatorRemarkupRuleIcon.php

Loading...

src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php

Loading...

src/applications/macro/remarkup/PhabricatorRemarkupRuleMeme.php

Loading...

src/applications/maniphest/remarkup/ManiphestRemarkupRule.php

Loading...

src/applications/passphrase/remarkup/PassphraseRemarkupRule.php

Loading...

src/applications/paste/remarkup/PhabricatorPasteRemarkupRule.php

Loading...

src/applications/people/application/PhabricatorPeopleApplication.php

Loading...

src/applications/people/markup/PhabricatorMentionRemarkupRule.php

Loading...

src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php

Loading...

src/applications/pholio/remarkup/PholioRemarkupRule.php

Loading...

src/applications/phriction/markup/PhrictionRemarkupRule.php

Loading...

src/applications/phriction/remarkup/PhrictionRemarkupRule.php

Loading...

src/applications/phriction/storage/PhrictionContent.php

Loading...

src/applications/ponder/remarkup/PonderRemarkupRule.php

Loading...

src/applications/project/remarkup/ProjectRemarkupRule.php

Loading...

src/applications/slowvote/remarkup/SlowvoteRemarkupRule.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...

src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterCowsay.php

Loading...

src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterFiglet.php

Loading...

src/infrastructure/markup/interpreter/PhabricatorRemarkupBlockInterpreterGraphviz.php

Loading...

src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php

Loading...

src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php

Loading...

src/infrastructure/markup/interpreter/PhabricatorRemarkupGraphvizBlockInterpreter.php

Loading...

src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php

Loading...

src/infrastructure/markup/rule/PhabricatorRemarkupCustomBlockRule.php

Loading...

src/infrastructure/markup/rule/PhabricatorRemarkupCustomInlineRule.php

Loading...

src/infrastructure/markup/rule/PhabricatorRemarkupRuleObject.php

Loading...

src/infrastructure/markup/rule/PhabricatorRemarkupRuleYoutube.php

Loading...

src/infrastructure/markup/rule/PhabricatorYoutubeRemarkupRule.php

Loading...