Page MenuHomePhabricator
Differential D9936

Don't export keys for non-associative arrays
ClosedPublic
Actions

Authored by joshuaspence on Jul 15 2014, 5:37 AM.
Tags
None
Referenced Files
F15491499: D9936.id.diff
Sat, Apr 12, 4:20 AM
F15490807: D9936.id23866.diff
Fri, Apr 11, 8:41 PM
F15484330: D9936.id24015.diff
Wed, Apr 9, 5:44 PM
F15466549: D9936.id24014.diff
Thu, Apr 3, 6:51 AM
F15425597: D9936.id24015.diff
Mar 23 2025, 4:59 AM
F15406640: D9936.id24014.diff
Mar 18 2025, 1:04 PM
F15399811: D9936.id23866.diff
Mar 17 2025, 7:51 AM
F15282452: D9936.id23837.diff
Mar 4 2025, 12:13 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU9853eacf937a: Don't export keys for non-associative arrays
Summary

phutil_var_export can produce cleaner output if keys are omitted for non-associative arrays. Depends on D9935.

Test Plan

arc unit

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23837.Jul 15 2014, 5:37 AM
joshuaspence retitled this revision from to Don't export keys for non-associative arrays.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D9935: Refactor `phutil_var_export`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 15 2014, 5:37 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1698: Diff 23837.Jul 15 2014, 5:38 AM
epriestley accepted this revision.Jul 15 2014, 4:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 15 2014, 4:15 PM
joshuaspence updated this revision to Diff 23866.Jul 16 2014, 11:03 AM
joshuaspence edited edge metadata.

Rebasing

Harbormaster completed remote builds in B1719: Diff 23866.Jul 16 2014, 11:04 AM
joshuaspence updated this revision to Diff 24014.Jul 20 2014, 11:23 PM

Rebasing after D9935

Harbormaster completed remote builds in B1798: Diff 24014.Jul 20 2014, 11:24 PM
joshuaspence closed this revision.Jul 20 2014, 11:27 PM
joshuaspence updated this revision to Diff 24015.

Closed by commit rPHU9853eacf937a (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
utils/
__tests__/
6 lines
7 lines

Diff 24015

View Options

src/utils/__tests__/PhutilUtilsTestCase.php

Loading...
View Options

src/utils/utils.php

Loading...
Phabricator · Built by Phacility