Page MenuHomePhabricator
Differential D9936

Don't export keys for non-associative arrays
ClosedPublic
Actions

Authored by joshuaspence on Jul 15 2014, 5:37 AM.
Tags
None
Referenced Files
F13883078: D9936.diff
Thu, Oct 3, 5:42 AM
Unknown Object (File)
Tue, Sep 24, 4:17 AM
Unknown Object (File)
Sat, Sep 14, 8:46 PM
Unknown Object (File)
Sat, Sep 14, 8:45 PM
Unknown Object (File)
Sat, Sep 14, 8:45 PM
Unknown Object (File)
Sat, Sep 14, 8:44 PM
Unknown Object (File)
Sat, Sep 14, 8:43 PM
Unknown Object (File)
Sat, Sep 14, 8:43 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU9853eacf937a: Don't export keys for non-associative arrays
Summary

phutil_var_export can produce cleaner output if keys are omitted for non-associative arrays. Depends on D9935.

Test Plan

arc unit

Diff Detail

Repository
rPHU libphutil
Branch
varexport-nonassoc_array
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1798
Build 1799: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23837.Jul 15 2014, 5:37 AM
joshuaspence retitled this revision from to Don't export keys for non-associative arrays.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D9935: Refactor `phutil_var_export`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 15 2014, 5:37 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1698: Diff 23837.Jul 15 2014, 5:38 AM
epriestley accepted this revision.Jul 15 2014, 4:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 15 2014, 4:15 PM
joshuaspence updated this revision to Diff 23866.Jul 16 2014, 11:03 AM
joshuaspence edited edge metadata.

Rebasing

Harbormaster completed remote builds in B1719: Diff 23866.Jul 16 2014, 11:04 AM
joshuaspence updated this revision to Diff 24014.Jul 20 2014, 11:23 PM

Rebasing after D9935

Harbormaster completed remote builds in B1798: Diff 24014.Jul 20 2014, 11:24 PM
joshuaspence closed this revision.Jul 20 2014, 11:27 PM
joshuaspence updated this revision to Diff 24015.

Closed by commit rPHU9853eacf937a (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
utils/
__tests__/
6 lines
7 lines

Diff 24014

View Options

src/utils/__tests__/PhutilUtilsTestCase.php

Loading...
View Options

src/utils/utils.php

Loading...
Phabricator · Built by Phacility