Paths

Table of Contentst

Differential D9936

Don't export keys for non-associative arrays
ClosedPublic
Actions

Authored by joshuaspence on Jul 15 2014, 5:37 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU9853eacf937a: Don't export keys for non-associative arrays

Summary

phutil_var_export can produce cleaner output if keys are omitted for non-associative arrays. Depends on D9935.

Test Plan

arc unit

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23837.Jul 15 2014, 5:37 AM

joshuaspence retitled this revision from to Don't export keys for non-associative arrays.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D9935: Refactor `phutil_var_export`.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 15 2014, 5:37 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1698: Diff 23837.Jul 15 2014, 5:38 AM

epriestley accepted this revision.Jul 15 2014, 4:15 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 15 2014, 4:15 PM

Rebasing

Harbormaster completed remote builds in B1719: Diff 23866.Jul 16 2014, 11:04 AM

Rebasing after D9935

Harbormaster completed remote builds in B1798: Diff 24014.Jul 20 2014, 11:24 PM

Closed by commit rPHU9853eacf937a (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

utils/

__tests__/

PhutilUtilsTestCase.php

6 lines

utils.php

7 lines

Diff 24015

View Options

src/utils/tests/PhutilUtilsTestCase.php

View Options

Don't export keys for non-associative arraysClosedPublicActions