Move scripts/phutil_rebuild_map.php and the PhutilLibraryMapBuilder class from rARC to rPHU. The intention here is to create a stronger ArcanistInfrastructureTestCase acceptance test (and the corresponding acceptance tests for rP and rPHU) by regenerating the library map file (to a temporary output) and comparing it to the existing library map file. This will be able to catch the case in which a new class/function has been added to a library, but arc liberate has not been executed.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPHUe01a8588a135: Move `PhutilLibraryMapBuilder` to `libphutil`
> ./scripts/phutil_rebuild_map.php src Finding source files... Found 344 files. Loading symbol cache... Found 344 files in cache. Building library map... Writing map... Done.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- liberate
- Lint
Lint Passed Severity Location Code Message Advice scripts/phutil_symbols.php:174 XHP16 TODO Comment Advice scripts/phutil_symbols.php:258 XHP16 TODO Comment - Unit
No Test Coverage - Build Status
Buildable 1508 Build 1508: [Placeholder Plan] Wait for 30 Seconds