Page MenuHomePhabricator

Move `PhutilLibraryMapBuilder` to `libphutil`
ClosedPublic

Authored by joshuaspence on Jul 3 2014, 10:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 8:00 PM
Unknown Object (File)
Wed, Nov 20, 6:51 AM
Unknown Object (File)
Tue, Nov 19, 12:03 AM
Unknown Object (File)
Tue, Nov 12, 11:59 AM
Unknown Object (File)
Sat, Nov 2, 10:21 PM
Unknown Object (File)
Oct 18 2024, 8:31 AM
Unknown Object (File)
Oct 17 2024, 9:47 AM
Unknown Object (File)
Oct 16 2024, 11:00 PM
Subscribers

Details

Summary

Move scripts/phutil_rebuild_map.php and the PhutilLibraryMapBuilder class from rARC to rPHU. The intention here is to create a stronger ArcanistInfrastructureTestCase acceptance test (and the corresponding acceptance tests for rP and rPHU) by regenerating the library map file (to a temporary output) and comparing it to the existing library map file. This will be able to catch the case in which a new class/function has been added to a library, but arc liberate has not been executed.

Test Plan
> ./scripts/phutil_rebuild_map.php src
Finding source files...
Found 344 files.
Loading symbol cache...
Found 344 files in cache.
Building library map...
Writing map...
Done.

Diff Detail

Repository
rPHU libphutil
Branch
liberate
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1505
Build 1505: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Move `scripts/phutil_rebuild_map.php` to rPHU.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Whoops, forgot PhutilLibraryMapBuilder

joshuaspence retitled this revision from Move `scripts/phutil_rebuild_map.php` to rPHU to Move `PhutilLibraryMapBuilder` to `libphutil`.Jul 3 2014, 10:31 PM
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
  • Also scripts/phutil_symbols.php
  • Also resources/php_compat_info.json
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 4 2014, 2:54 PM