Page MenuHomePhabricator

Move `PhutilLibraryMapBuilder` to `libphutil`
ClosedPublic

Authored by joshuaspence on Jul 3 2014, 10:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 3:22 PM
Unknown Object (File)
Wed, Apr 24, 10:24 PM
Unknown Object (File)
Sat, Apr 20, 7:12 PM
Unknown Object (File)
Tue, Apr 9, 12:36 PM
Unknown Object (File)
Mar 31 2024, 5:29 PM
Unknown Object (File)
Mar 29 2024, 12:25 AM
Unknown Object (File)
Mar 10 2024, 4:27 PM
Unknown Object (File)
Feb 20 2024, 1:46 PM
Subscribers

Details

Summary

Move scripts/phutil_rebuild_map.php and the PhutilLibraryMapBuilder class from rARC to rPHU. The intention here is to create a stronger ArcanistInfrastructureTestCase acceptance test (and the corresponding acceptance tests for rP and rPHU) by regenerating the library map file (to a temporary output) and comparing it to the existing library map file. This will be able to catch the case in which a new class/function has been added to a library, but arc liberate has not been executed.

Test Plan
> ./scripts/phutil_rebuild_map.php src
Finding source files...
Found 344 files.
Loading symbol cache...
Found 344 files in cache.
Building library map...
Writing map...
Done.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Move `scripts/phutil_rebuild_map.php` to rPHU.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Whoops, forgot PhutilLibraryMapBuilder

joshuaspence retitled this revision from Move `scripts/phutil_rebuild_map.php` to rPHU to Move `PhutilLibraryMapBuilder` to `libphutil`.Jul 3 2014, 10:31 PM
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
  • Also scripts/phutil_symbols.php
  • Also resources/php_compat_info.json
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 4 2014, 2:54 PM