Page MenuHomePhabricator

Remove all `device = true` from page construction
ClosedPublic

Authored by epriestley on Jun 23 2014, 5:26 PM.
Tags
None
Referenced Files
F19227457: D9690.id23251.diff
Fri, Dec 19, 4:46 AM
F19103306: D9690.id23248.diff
Fri, Dec 5, 9:28 AM
F19093626: D9690.id23248.diff
Wed, Dec 3, 9:58 PM
F19093625: D9690.id23251.diff
Wed, Dec 3, 9:58 PM
F19093624: D9690.id23284.diff
Wed, Dec 3, 9:58 PM
F18944196: D9690.largetrue.diff
Nov 11 2025, 3:31 PM
F18933546: D9690.diff
Nov 10 2025, 11:46 AM
F18813714: D9690.largetrue.diff
Oct 20 2025, 6:45 PM

Details

Summary

Fixes T5446. Depends on D9687.

Test Plan

Mostly regexp'd this. Lint doesn't complain.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Remove all `device = true` from page construction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

For this, which shows just changed lines:

$ git diff HEAD^ -U0 | grep -v '^diff' | grep -v '^index' | grep -v '^---' | grep -v '^+++' | grep -v '^@@' | sort | uniq -c

This is the output:

 15 +      ));
  1 -            'device' => true,
  1 -          'device' => true,
  2 -        'device'    => true,
 11 -        'device'  => true,
  2 -        'device' => true
 15 -        'device' => true));
166 -        'device' => true,
  • Accidentally removed some false values.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2014, 8:35 PM
epriestley updated this revision to Diff 23284.

Closed by commit rP46d9bebc8430 (authored by @epriestley).