Page MenuHomePhabricator
Create Task
Maniphest T5446

Remove device = true from all pages
Closed, ResolvedPublic
Actions

Description

There are probably only a handful of pages not converted, and likely most of those will display fine if they are using any recent components.

Revisions and Commits

rP Phabricator
D9690rP46d9bebc8430 Remove all `device = true` from page construction
D9687rPca6bd2647588 Set `device` to `false` for all pages which don't specify device readiness

Event Timeline

chad created this task.Jun 23 2014, 4:00 PM
chad raised the priority of this task from to Normal.
chad updated the task description. (Show Details)
chad added a project: Mobile.
chad added subscribers: chad, epriestley, btrahan.
epriestley claimed this task.Jun 23 2014, 4:56 PM
epriestley edited this Maniphest Task.Jun 23 2014, 5:08 PM
epriestley edited this Maniphest Task.Jun 23 2014, 5:26 PM
epriestley added a comment.Jun 23 2014, 5:36 PM

We also still have a handful of buildStandardPageResponse() calls from two generations ago (before buildApplicationPage()) -- looks like about 20 in total. I don't think it's too value to go specifically clean these up right now, though -- none of them look like they're anywhere important.

epriestley edited this Maniphest Task.Jun 23 2014, 10:15 PM
epriestley edited this Maniphest Task.Jun 23 2014, 10:18 PM
epriestley closed this task as Resolved.Jun 23 2014, 10:18 PM

Closed by commit rP46d9bebc8430.

Phabricator · Built by Phacility