Page MenuHomePhabricator

Remove all `device = true` from page construction
ClosedPublic

Authored by epriestley on Jun 23 2014, 5:26 PM.
Tags
None
Referenced Files
F13163401: D9690.diff
Mon, May 6, 7:47 PM
Unknown Object (File)
Fri, May 3, 6:44 AM
Unknown Object (File)
Wed, May 1, 10:47 PM
Unknown Object (File)
Wed, Apr 24, 10:34 PM
Unknown Object (File)
Mon, Apr 22, 6:07 AM
Unknown Object (File)
Wed, Apr 17, 3:17 PM
Unknown Object (File)
Tue, Apr 9, 12:15 PM
Unknown Object (File)
Mar 29 2024, 10:20 AM

Details

Summary

Fixes T5446. Depends on D9687.

Test Plan

Mostly regexp'd this. Lint doesn't complain.

Diff Detail

Repository
rP Phabricator
Branch
device2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1331
Build 1331: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Remove all `device = true` from page construction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

For this, which shows just changed lines:

$ git diff HEAD^ -U0 | grep -v '^diff' | grep -v '^index' | grep -v '^---' | grep -v '^+++' | grep -v '^@@' | sort | uniq -c

This is the output:

 15 +      ));
  1 -            'device' => true,
  1 -          'device' => true,
  2 -        'device'    => true,
 11 -        'device'  => true,
  2 -        'device' => true
 15 -        'device' => true));
166 -        'device' => true,
  • Accidentally removed some false values.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2014, 8:35 PM
epriestley updated this revision to Diff 23284.

Closed by commit rP46d9bebc8430 (authored by @epriestley).