Page MenuHomePhabricator

Remove all `device = true` from page construction
ClosedPublic

Authored by epriestley on Jun 23 2014, 5:26 PM.
Tags
None
Referenced Files
F14054685: D9690.diff
Sat, Nov 16, 3:59 AM
F14044010: D9690.diff
Tue, Nov 12, 2:38 PM
F14033567: D9690.id.largetrue.diff
Sat, Nov 9, 6:16 PM
F14028590: D9690.diff
Fri, Nov 8, 2:15 PM
F14001374: D9690.id.diff
Fri, Oct 25, 7:07 AM
F13999639: D9690.diff
Thu, Oct 24, 4:07 PM
F13991226: D9690.id23248.largetrue.diff
Tue, Oct 22, 9:22 AM
F13974132: D9690.id.diff
Oct 18 2024, 4:14 AM

Details

Summary

Fixes T5446. Depends on D9687.

Test Plan

Mostly regexp'd this. Lint doesn't complain.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Remove all `device = true` from page construction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

For this, which shows just changed lines:

$ git diff HEAD^ -U0 | grep -v '^diff' | grep -v '^index' | grep -v '^---' | grep -v '^+++' | grep -v '^@@' | sort | uniq -c

This is the output:

 15 +      ));
  1 -            'device' => true,
  1 -          'device' => true,
  2 -        'device'    => true,
 11 -        'device'  => true,
  2 -        'device' => true
 15 -        'device' => true));
166 -        'device' => true,
  • Accidentally removed some false values.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2014, 8:35 PM
epriestley updated this revision to Diff 23284.

Closed by commit rP46d9bebc8430 (authored by @epriestley).