Don't run "aphlict-listen" behavior if real-time notifications are disabled
ClosedPublic
Actions

Authored by epriestley on Jun 7 2014, 7:45 PM.

Tags

None

Referenced Files

	F13183045: D9418.id.diff
	Fri, May 10, 6:31 AM

	Unknown Object (File)
	Sun, May 5, 5:30 AM

	Unknown Object (File)
	Sun, May 5, 4:11 AM

	Unknown Object (File)
	Tue, Apr 30, 1:38 PM

	Unknown Object (File)
	Apr 12 2024, 9:36 AM

	Unknown Object (File)
	Apr 12 2024, 8:15 AM

	Unknown Object (File)
	Apr 12 2024, 8:09 AM

	Unknown Object (File)
	Apr 6 2024, 6:49 AM

View All Files

Subscribers

epriestley

Details

Reviewers

joshuaspence

Maniphest Tasks

T5277: Aphlict client is started even if notifications are disabled

Commits

Restricted Diffusion Commit
rP96d5a9b4c2ef: Don't run "aphlict-listen" behavior if real-time notifications are disabled

Summary

Fixes T5277. We incorrectly ran this unconditionally.

Test Plan

Toggled setting on/off, verified behavior ran or did not run.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22491.Jun 7 2014, 7:45 PM

epriestley retitled this revision from to Don't run "aphlict-listen" behavior if real-time notifications are disabled.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: joshuaspence.

epriestley added a task: T5277: Aphlict client is started even if notifications are disabled.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 7 2014, 7:45 PM

Harbormaster completed remote builds in B917: Diff 22491.Jun 7 2014, 7:46 PM

I was thinking it would be much harder than this.

This revision is now accepted and ready to land.Jun 7 2014, 7:50 PM

Closed by commit rP96d5a9b4c2ef (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

view/

page/

PhabricatorStandardPageView.php

79 lines

Diff 22492

View Options

src/view/page/PhabricatorStandardPageView.php

Don't run "aphlict-listen" behavior if real-time notifications are disabledClosedPublicActions