Page MenuHomePhabricator

Don't run "aphlict-listen" behavior if real-time notifications are disabled
ClosedPublic

Authored by epriestley on Jun 7 2014, 7:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 2, 6:42 AM
Unknown Object (File)
Mon, Dec 30, 8:22 AM
Unknown Object (File)
Sun, Dec 29, 1:01 AM
Unknown Object (File)
Sat, Dec 28, 12:09 PM
Unknown Object (File)
Sat, Dec 21, 7:05 AM
Unknown Object (File)
Tue, Dec 17, 9:26 PM
Unknown Object (File)
Tue, Dec 10, 2:50 AM
Unknown Object (File)
Dec 4 2024, 6:56 PM
Subscribers

Details

Summary

Fixes T5277. We incorrectly ran this unconditionally.

Test Plan

Toggled setting on/off, verified behavior ran or did not run.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't run "aphlict-listen" behavior if real-time notifications are disabled.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
joshuaspence edited edge metadata.

I was thinking it would be much harder than this.

This revision is now accepted and ready to land.Jun 7 2014, 7:50 PM
epriestley updated this revision to Diff 22492.

Closed by commit rP96d5a9b4c2ef (authored by @epriestley).