Page MenuHomePhabricator

Don't run "aphlict-listen" behavior if real-time notifications are disabled
ClosedPublic

Authored by epriestley on Jun 7 2014, 7:45 PM.
Tags
None
Referenced Files
F18400338: D9418.diff
Fri, Aug 29, 5:58 PM
F18111556: D9418.diff
Tue, Aug 12, 11:09 AM
F18090345: D9418.id22492.diff
Wed, Aug 6, 3:20 PM
F18087192: D9418.id22491.diff
Wed, Aug 6, 2:59 AM
F17867525: D9418.id.diff
Jul 28 2025, 6:17 AM
F17846757: D9418.diff
Jul 27 2025, 5:17 AM
Unknown Object (File)
Jun 18 2025, 4:39 AM
Unknown Object (File)
Jun 18 2025, 4:39 AM
Subscribers

Details

Summary

Fixes T5277. We incorrectly ran this unconditionally.

Test Plan

Toggled setting on/off, verified behavior ran or did not run.

Diff Detail

Repository
rP Phabricator
Branch
nolisten
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 917
Build 917: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Don't run "aphlict-listen" behavior if real-time notifications are disabled.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
joshuaspence edited edge metadata.

I was thinking it would be much harder than this.

This revision is now accepted and ready to land.Jun 7 2014, 7:50 PM
epriestley updated this revision to Diff 22492.

Closed by commit rP96d5a9b4c2ef (authored by @epriestley).