Page MenuHomePhabricator

Aphlict client is started even if notifications are disabled
Closed, ResolvedPublic

Description

It seems that the Aphlict client (that is, aphlict.swf) is included and executed even if notification.enabled is set to false.

Event Timeline

joshuaspence claimed this task.
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Aphlict.
joshuaspence added subscribers: joshuaspence, epriestley.

Some discussion on chatlog.

<rmmh> what does '(Aphlict) Error #2048' mean?
<rmmh> hm, something about cross-domain?
<joshuaspence> @rmmh, yes it looks like a security issue
<rmmh> is this why I'm not getting notifications?
<joshuaspence> i think it would explain it
<joshuaspence> are you using multiple domains or something?
<rmmh> not intentionally. might have a domain misconfigured somewhere
<rmmh> there's no /crossdomain.xml on the server
<joshuaspence> the crossdomain.xml is served through the aphlict node server i believe
<joshuaspence> are you able to turn on notification.debug and see what is happening?
<rmmh> oh. notification.client-uri is localhost, that looks wrong
<joshuaspence> no that's correct
<joshuaspence> (if you are running aphlict on the same host that is serving phabricator)
<rmmh> well I don't have it running at all
<joshuaspence> what do you mean?
<rmmh> I don't have the aphlict server running
<rmmh> missed that part of the config guide
<joshuaspence> ok
<joshuaspence> i wouldn't think that would cause an error to be issued. rather, i'd have expected the notifications to just not work at all.
<joshuaspence> but maybe
<rmmh> so I guess the real bug is that notification.enabled=false, yet it's still doing this stuff
<joshuaspence> oh..
<joshuaspence> it is?
<joshuaspence> hmm
<joshuaspence> let me check
<rmmh> I never enabled notifications, but I'm getting that error
<rmmh> guess it's a hint that I should fix them? :)
<joshuaspence> hmm. i'm not able to replicate this
<joshuaspence> i created a ticket though, since definitely some Aphlict stuff is happening even when `notification.enabled` is false

I think in order to fix this, Aphlict should be moved out of core.pkg.js and it should only be included if PhabricatorEnv::getEnvConfig('notification.enabled') is true.

I get a "(Aphlict) Error #2048" even when Aphlict is running.

@fzhan, usually this is a firewall issue. Are you able to connect to port 843 on the host?

@joshuaspence thank you, that explained it! I had iptables blocking this port.