Don't run "aphlict-listen" behavior if real-time notifications are disabled
ClosedPublic
Actions

Authored by epriestley on Jun 7 2014, 7:45 PM.

Tags

None

Referenced Files

	F18824704: D9418.id22491.diff
	Thu, Oct 23, 5:27 PM

	F18759017: D9418.id22492.diff
	Mon, Oct 6, 1:12 AM

	F18759016: D9418.id22491.diff
	Mon, Oct 6, 1:12 AM

	F18740557: D9418.id.diff
	Thu, Oct 2, 3:58 AM

	F18735913: D9418.diff
	Wed, Oct 1, 3:59 AM

	F18734932: D9418.id.diff
	Tue, Sep 30, 11:06 PM

	F18621156: D9418.diff
	Sep 15 2025, 7:15 AM

	F18597438: D9418.diff
	Sep 13 2025, 2:53 AM

View All Files

Subscribers

epriestley

Details

Reviewers

joshuaspence

Maniphest Tasks

T5277: Aphlict client is started even if notifications are disabled

Commits

Restricted Diffusion Commit
rP96d5a9b4c2ef: Don't run "aphlict-listen" behavior if real-time notifications are disabled

Summary

Fixes T5277. We incorrectly ran this unconditionally.

Test Plan

Toggled setting on/off, verified behavior ran or did not run.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22491.Jun 7 2014, 7:45 PM

epriestley retitled this revision from to Don't run "aphlict-listen" behavior if real-time notifications are disabled.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: joshuaspence.

epriestley added a task: T5277: Aphlict client is started even if notifications are disabled.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 7 2014, 7:45 PM

Harbormaster completed remote builds in B917: Diff 22491.Jun 7 2014, 7:46 PM

I was thinking it would be much harder than this.

This revision is now accepted and ready to land.Jun 7 2014, 7:50 PM

Closed by commit rP96d5a9b4c2ef (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

view/

page/

PhabricatorStandardPageView.php

79 lines

Diff 22492

View Options

src/view/page/PhabricatorStandardPageView.php

Don't run "aphlict-listen" behavior if real-time notifications are disabledClosedPublicActions