Fixes T4720. Allows non-authors to permanently reject a differential by exposing the "Abandon Revision" action via a configuration flag.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4720: Expose "Abandon Revision" to non-authors with a config flag
- Commits
- Restricted Diffusion Commit
rP1e2a592ceb36: Expose "Abandon Revision" to non-authors with a config flag.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
(This looks good to me but I'll wait for an actual test. It should also special case the "username abandoned this revision." string if the actor isn't the author.)
Comment Actions
Ok. So I've tested this and it seems to be working.
A couple of minor things I noticed:
- The bubble (not sure of the proper name) next to the reviewer stayed at "Reviewed Requested".
- I am not sure how/where to change the text depending on whether or not the author is the owner of the diff.
Comment Actions
Ok, so the issue with the reviewer status seems to be because I didn't do anything to the DifferentialReviewerStatus code. We could either add DifferentialReviewerStatus::STATUS_ABANDONED or squash it in with DifferentialReviewerStatus::STATUS_REJECTED.
Comment Actions
Actually it seems that this behavior is expected. This is the behaviour currently when the author abandons a diff, so I don't think that this behavior is unreasonable.
Comment Actions
It would be nice to special case the story text in DifferentialTransaction::getTitle() and DifferentialTransaction::getTitleForFeed() but I guess that's a bit of a pain.
Comment Actions
Closed by commit rP1e2a592ceb36 (authored by @joshuaspence, committed by @epriestley).