Page MenuHomePhabricator

Expose "Abandon Revision" to non-authors with a config flag
Closed, ResolvedPublic

Description

Via IRC, see chatlog for details.

The use case is that an open source install receives highly-questionable patches and would like a more definitive "no, this is never going to work" action than "Request Changes" presents. A particular concern was in making the action unambiguous to users who don't speak English as a first language; some of the euphemistic language crafted to avoid hurting feelings at Facebook is difficult for non-native speakers to understand, because it isn't very direct or clear.

A reasonable solution here is to expose the "Abandon" action to non-authors, with text like "Reject Permanently" or "Reject Completely". The transaction text for these actions should make the intent clear too (e.g., "alincoln permanently rejected this change.").

Related Objects