Page MenuHomePhabricator
Differential D9208

Show daemon arguments with `./bin/phd status`.
ClosedPublic
Actions

Authored by joshuaspence on May 19 2014, 11:00 PM.
Tags
None
Referenced Files
F13794617: D9208.diff
Sat, Sep 14, 5:11 AM
Unknown Object (File)
Fri, Sep 6, 1:20 AM
Unknown Object (File)
Tue, Sep 3, 11:11 AM
Unknown Object (File)
Sun, Sep 1, 7:36 AM
Unknown Object (File)
Sun, Sep 1, 7:36 AM
Unknown Object (File)
Sun, Sep 1, 7:36 AM
Unknown Object (File)
Sun, Sep 1, 7:36 AM
Unknown Object (File)
Sun, Sep 1, 7:36 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4735: `phd status` should show daemon arguments
Commits
Restricted Diffusion Commit
rPeba11238b921: Show daemon arguments with `./bin/phd status`.
Summary

Fixes T4735. When running ./bin/phd, show daemon arguments.

Test Plan
./bin/phd status
PID  	Started                 	Daemon                                            Arguments
12711	May 20 2014, 9:02:52 AM 	PhabricatorRepositoryPullLocalDaemon              []
12716	May 20 2014, 9:02:52 AM 	PhabricatorGarbageCollectorDaemon                 []
12733	May 20 2014, 9:02:53 AM 	PhabricatorTaskmasterDaemon                       []
12768	May 20 2014, 9:02:53 AM 	PhabricatorTaskmasterDaemon                       []
12775	May 20 2014, 9:02:53 AM 	PhabricatorTaskmasterDaemon                       []
12780	May 20 2014, 9:02:54 AM 	PhabricatorTaskmasterDaemon                       []
12838	May 20 2014, 9:02:54 AM 	PhabricatorFactDaemon                             []
13436	May 20 2014, 9:03:23 AM 	PhabricatorRepositoryPullLocalDaemon              ["X","--not","Y"]

Diff Detail

Repository
rP Phabricator
Branch
phd-args
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 586
Build 586: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21870.May 19 2014, 11:00 PM
joshuaspence retitled this revision from to Show daemon arguments with `./bin/phd status`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T4735: `phd status` should show daemon arguments.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 19 2014, 11:00 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B585: Diff 21870.May 19 2014, 11:01 PM
joshuaspence updated this revision to Diff 21871.May 19 2014, 11:01 PM
joshuaspence edited edge metadata.

json_encode the arguments

Harbormaster completed remote builds in B586: Diff 21871.May 19 2014, 11:02 PM
joshuaspence updated this revision to Diff 21872.May 19 2014, 11:04 PM

Reduce the width of the "Daemon" column.

joshuaspence edited the test plan for this revision. (Show Details)May 19 2014, 11:05 PM
Harbormaster completed remote builds in B587: Diff 21872.May 19 2014, 11:05 PM
joshuaspence added a parent revision: D9207: Store daemon arguments in reference file..May 20 2014, 10:27 PM
epriestley edited edge metadata.May 20 2014, 10:31 PM

As with D9205, maybe csprintf + readable argument? I'm onboard with this if that sounds like a pain.

joshuaspence added a parent revision: D9229: Add `%LR` support to `csprintf`..May 20 2014, 11:34 PM
joshuaspence updated this revision to Diff 21919.May 20 2014, 11:35 PM
joshuaspence edited edge metadata.

Use csprintf('%LR', $daemon->getArgv()) instead of json_encode($daemon->getArgv()).

Harbormaster completed remote builds in B616: Diff 21919.May 20 2014, 11:36 PM
epriestley accepted this revision.May 20 2014, 11:47 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 20 2014, 11:47 PM
epriestley closed this revision.May 20 2014, 11:47 PM
epriestley updated this revision to Diff 21921.

Closed by commit rPeba11238b921 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
daemon/
management/
14 lines
infrastructure/
daemon/
control/
6 lines

Diff 21871

View Options

src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php

Loading...
View Options

src/infrastructure/daemon/control/PhabricatorDaemonReference.php

Loading...
Phabricator · Built by Phacility