Page MenuHomePhabricator

Add `%LR` support to `csprintf`.
ClosedPublic

Authored by joshuaspence on May 20 2014, 11:28 PM.
Tags
None
Referenced Files
F18810308: D9229.id.diff
Sun, Oct 19, 9:00 PM
F18806237: D9229.diff
Sat, Oct 18, 6:34 PM
F18763645: D9229.diff
Tue, Oct 7, 1:17 AM
F18740425: D9229.id21917.diff
Thu, Oct 2, 3:04 AM
F18722998: D9229.id21916.diff
Mon, Sep 29, 11:43 PM
F18721636: D9229.id21917.diff
Mon, Sep 29, 9:27 PM
F18716354: D9229.diff
Mon, Sep 29, 11:49 AM
F18672998: D9229.id21916.diff
Thu, Sep 25, 9:00 AM
Subscribers

Details

Summary

Allow csprintf to format an array of readable strings.

Test Plan

I didn't create any test cases because there aren't any existing test cases for csprintf. Instead, I used the following script:

<?php

require_once __DIR__.'/scripts/__init_script__.php';

echo csprintf('%LR', array('foo', '--not', 'bar'))."\n";
echo csprintf('%LR', array('foo', '--not bar'))."\n";

The output was as follows:

foo --not bar
foo '--not bar'

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Add `%LR` support to `csprintf`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 20 2014, 11:29 PM
epriestley updated this revision to Diff 21917.

Closed by commit rPHU1ba1de50e9ee (authored by @joshuaspence, committed by @epriestley).