Ref T4735. When launching daemons (with ./bin/phd start or ./bin/phd launch), print the arguments that are specified for the daemon.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4735: `phd status` should show daemon arguments
- Commits
- Restricted Diffusion Commit
rPb6d15377dda0: Show daemon arguments when launching a daemon with `./bin/phd`.
Ran ./bin/phd launch repo -- --not X.
> sudo ./bin/phd launch repo -- --not X Preparing to launch daemons. NOTE: Logs will appear in '/mnt/logs/phd/daemons.log'. Launching daemon "PhabricatorRepositoryPullLocalDaemon" with arguments ["--not","X"].
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
What do you think about using csprintf('%R', $arg) here ("readable argument"), or adding csprintf('%LR', $argv) for a list of %R, instead of JSON?
Happy to accept/pull this as-is if you don't want to bother doing the lifting, we can always clean it up later.
Comment Actions
Closed by commit rPb6d15377dda0 (authored by @joshuaspence, committed by @epriestley).