Fixes T4951. Whilst xhpast was originally intended to be an internal development tool, it is not unreasonable for ArcanistXHPASTLinter to be used externally. Currently, however, if the compiled version of xhpast is not up-to-date, we simply exit and ask the user to build XHPAST themselves. Instead, let's try to build XHPAST automatically.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4951: Automatically build XHPAST when possible
- Commits
- rPHU4b85681758d7: Attempt to automatically build XHPAST.
Removed ./src/parser/xhpast/bin/xhpast and ran arc lint over a PHP file. Verified that the xhpast binary was created during this process.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- autobuild-xhpast
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 400 Build 400: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Closed by commit rPHU4b85681758d7 (authored by @joshuaspence, committed by @epriestley).