HomePhabricator

Attempt to automatically build XHPAST.

Description

Attempt to automatically build XHPAST.

Summary: Fixes T4951. Whilst xhpast was originally intended to be an internal development tool, it is not unreasonable for ArcanistXHPASTLinter to be used externally. Currently, however, if the compiled version of xhpast is not up-to-date, we simply exit and ask the user to build XHPAST themselves. Instead, let's try to build XHPAST automatically.

Test Plan: Removed ./src/parser/xhpast/bin/xhpast and ran arc lint over a PHP file. Verified that the xhpast binary was created during this process.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T4951

Differential Revision: https://secure.phabricator.com/D9076

Details

Provenance
joshuaspenceAuthored on
epriestleyCommitted on May 12 2014, 2:34 PM
epriestleyPushed on May 12 2014, 2:34 PM
Reviewer
Blessed Reviewers
Differential Revision
D9076: Attempt to automatically build XHPAST.
Parents
rPHU8ac1de09df40: Add phutil-library linter to libphutil
Branches
Unknown
Tags
Unknown
Tasks
T4951: Automatically build XHPAST when possible

Event Timeline