Provide viewer to CustomFields in ApplicationSearch
ClosedPublic
Actions

Authored by epriestley on Mar 22 2014, 11:55 PM.

Tags

None

Referenced Files

	F19102978: D8595.id.diff
	Fri, Dec 5, 8:14 AM

	F19095852: D8595.diff
	Thu, Dec 4, 6:49 AM

	F19093178: D8595.id20381.diff
	Wed, Dec 3, 8:35 PM

	F19056235: D8595.id20381.diff
	Fri, Nov 28, 7:13 PM

	F19050880: D8595.id20420.diff
	Thu, Nov 27, 10:36 PM

	F19030368: D8595.id.diff
	Nov 24 2025, 8:55 PM

	F19011658: D8595.id.diff
	Nov 22 2025, 10:49 AM

	F18856185: D8595.id.diff
	Nov 1 2025, 8:24 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
carl

Maniphest Tasks

T4663: Custom fields in saved searches are not passed a viewer

Commits

Restricted Diffusion Commit
rP07fdcde87eaf: Provide viewer to CustomFields in ApplicationSearch

Summary

Fixes T4663.

Test Plan

Added a custom field which accesses the viewer's username.

Screen_Shot_2014-03-22_at_4.53.45_PM.png (203×352 px, 16 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20381.Mar 22 2014, 11:55 PM

epriestley retitled this revision from to Provide viewer to CustomFields in ApplicationSearch.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, carl.

epriestley added a task: T4663: Custom fields in saved searches are not passed a viewer.

Herald added a subscriber: epriestley.Mar 22 2014, 11:55 PM

btrahan accepted this revision.Mar 25 2014, 7:47 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 25 2014, 7:47 PM

Closed by commit rP07fdcde87eaf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorApplicationSearchEngine.php

1 line

Diff 20420

View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Provide viewer to CustomFields in ApplicationSearchClosedPublicActions