Page MenuHomePhabricator
Create Task
Maniphest T4663

Custom fields in saved searches are not passed a viewer
Closed, ResolvedPublic
Actions

Description

When custom fields are asked to apply their search constraints to a query in applyCustomFieldsToQuery (possibly elsewhere, I haven't dug), applyApplicationSearchConstraintToQuery is called before a viewer is set.

A minimal failing test case (drop in src/extensions and try to search for something in Maniphest): {F133066}

This can be fixed with something like $field->setViewer($this->requireViewer()); in that foreach loop, but I don't really understand the implications of doing that well enough to send you a diff.

My particular use case here is to allow a custom search field to use the viewer's timezone to parse a time.

Revisions and Commits

rP Phabricator
D8598rP8e8818783599 Allow filtering of "date" custom fields
D8595rP07fdcde87eaf Provide viewer to CustomFields in ApplicationSearch

Event Timeline

carl created this task.Mar 22 2014, 8:21 AM
carl raised the priority of this task from to Needs Triage.
carl updated the task description. (Show Details)
carl added a subscriber: carl.
epriestley edited this Maniphest Task.Mar 22 2014, 11:55 PM
epriestley added a subscriber: epriestley.Mar 22 2014, 11:59 PM

Not sure how custom this custom field is, but if the standard date control would be satisfactory (but for the lack of search support) we can also add that, it's just a legwork issue and not a technical or product issue. (See also T4659, although that primarily discusses sorting rather than filtering.)

Even if it's fairly custom, it might be simpler to implement with range queries against custom field storage supported by the upstream.

carl added a comment.Mar 23 2014, 1:13 AM

It's 80% boilerplate and 20% sketchy code for "snap to previous monday and format it as %Y-%m-d" (this is to implement barebones weekly milestone support). A date control with search and sorting/grouping support would have been about 100 times more cargo-cultable (or proxyable), but the code is already written :P

Relatedly, I discovered that custom date fields weren't supported in search by accidentally stumbling upon a TODO while writing the above. It would be nice to maybe mention this in the custom field docs :)

epriestley edited this Maniphest Task.Mar 23 2014, 6:36 AM
epriestley added a comment.Mar 23 2014, 6:48 AM

(Sounds like it's moot in your case, but that at least fixes the need to fix the documentation.)

epriestley edited this Maniphest Task.Mar 25 2014, 9:02 PM
epriestley closed this task as Resolved.Mar 25 2014, 9:02 PM

Closed by commit rP07fdcde87eaf.

carl added a comment.Mar 25 2014, 9:19 PM

RE: D8598 — amazing! Thanks :)

epriestley edited this Maniphest Task.Mar 25 2014, 9:21 PM
Phabricator · Built by Phacility