Details
- Reviewers
btrahan - Maniphest Tasks
- T4659: Cannot use custom "date" field for sorting
T4663: Custom fields in saved searches are not passed a viewer - Commits
- Restricted Diffusion Commit
rP8e8818783599: Allow filtering of "date" custom fields
- Added a custom "date" field with "search".
- Populated some values.
- Searched for dates using new range filters.
- Combined date search with other searches.
- Ran other searches independently.
- Inspected the generated queries.
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
After patching this and attempting to run a query against my custom "due date" field, I got this error:
Argument 2 passed to PhabricatorTime::parseLocalTime() must be an instance of PhabricatorUser, null given, called in /Checkout/facebook/phabricator/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php on line 116 and defined
For reference, my query attempted to use "Before Due Date" with a value of "4-1-2014".
It appears as if I was not logged in while running the query, but I was definitely logged in (my instance does not allow anonymous access).
Attempting to patch on top of D8595 gives me an empty commit error. Not sure what is going on there...
Doh, forgot that adding dependencies to diffs automatically handles the diffs. Patch works fine now, but the filters don't appear to work:
Nevermind, it looks like that is just crappy parsing of the date by the filter... If I use a more verbose date, it works properly:
src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php | ||
---|---|---|
534 | s/contraint/constraint |
Is that search/group by custom fields works in latest release from this week?
I'm in need of that but can't see any custom field (added in Maniphest) in search query task interface.
Thanks for answers