Page MenuHomePhabricator

Support Herald rules for new Differential edits
ClosedPublic

Authored by epriestley on Mar 5 2014, 3:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 6:23 PM
Unknown Object (File)
Wed, Dec 4, 12:44 PM
Unknown Object (File)
Tue, Dec 3, 11:07 PM
Unknown Object (File)
Wed, Nov 27, 12:27 AM
Unknown Object (File)
Wed, Nov 27, 12:27 AM
Unknown Object (File)
Wed, Nov 27, 12:27 AM
Unknown Object (File)
Wed, Nov 27, 12:27 AM
Unknown Object (File)
Nov 19 2024, 5:11 PM
Subscribers

Details

Summary

Ref T2222. Ref T4484. See D8404 for discussion.

When a revision is updated with the new Editor, apply Herald rules. Additionally, apply them in a modern way which generates transactions.

Test Plan

{F122299}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Need to probably get rid of the line or have a Herald Icon as the actor in timeline, not sure which would look better.

I was planning to just wipe out the line, but be my guest if you want to do something fancier.

(I was also thinking of maybe putting an icon or something next to these so it's more clear that "Herald" is not just some guy named "Herald", but haven't played around with that.)

btrahan edited edge metadata.

I like these transactions being visible, and then I like the Herald application icon being the actor to make them more noticeable.

Herald discovery has always struck me as a bit tricky, so I think its nice to surface it this way. Also, I personally think the transaction log should be definitive-ish in terms of figuring out how people got subscribed, etc.

This revision is now accepted and ready to land.Mar 5 2014, 6:52 PM

I'll followup with at least a basic fix for the UI once I dig through some Diviner stuff.