Details
- Reviewers
btrahan - Maniphest Tasks
- T2222: Implement ApplicationTransactions in Differential
T4484: Show Herald effects on objects in object transaction logs - Commits
- Restricted Diffusion Commit
rP2ceffadee78a: Support Herald rules for new Differential edits
{F122299}
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Need to probably get rid of the line or have a Herald Icon as the actor in timeline, not sure which would look better.
I was planning to just wipe out the line, but be my guest if you want to do something fancier.
(I was also thinking of maybe putting an icon or something next to these so it's more clear that "Herald" is not just some guy named "Herald", but haven't played around with that.)
I like these transactions being visible, and then I like the Herald application icon being the actor to make them more noticeable.
Herald discovery has always struck me as a bit tricky, so I think its nice to surface it this way. Also, I personally think the transaction log should be definitive-ish in terms of figuring out how people got subscribed, etc.
I'll followup with at least a basic fix for the UI once I dig through some Diviner stuff.