Page MenuHomePhabricator

Add Branch and Arcanist Project CustomFields
ClosedPublic

Authored by epriestley on Feb 27 2014, 5:58 PM.
Tags
None
Referenced Files
F15512894: D8359.id.diff
Thu, Apr 17, 2:40 PM
F15509105: D8359.diff
Wed, Apr 16, 9:39 AM
F15429863: D8359.diff
Mar 24 2025, 4:40 AM
F15413382: D8359.id19872.diff
Mar 19 2025, 6:22 PM
F15411778: D8359.id19872.diff
Mar 19 2025, 9:47 AM
F15411757: D8359.id19872.diff
Mar 19 2025, 9:43 AM
F15411739: D8359.id19872.diff
Mar 19 2025, 9:41 AM
F15410317: D8359.id19872.diff
Mar 19 2025, 7:04 AM
Subscribers

Details

Summary

Ref T2222. These are pretty straightforward.

For these fields and a few others, the existing code shows the value for the "current/manual" diff (i.e., the diff selected in the diff selection table), not the "active" diff (i.e., the most recent diff attached to the revision). I'm going to drop that for now (always showing the most recent diff instead) and then reevaluate it once we're switched over. In 95% of cases these are the same, anyway.

Test Plan

Looked at fields; this diff changes nothing on its own.

Diff Detail

Repository
rP Phabricator
Branch
mfield1
Lint
Lint Passed
Unit
Tests Passed