Page MenuHomePhabricator

Add Branch and Arcanist Project CustomFields
ClosedPublic

Authored by epriestley on Feb 27 2014, 5:58 PM.
Tags
None
Referenced Files
F11535559: D8359.diff
Mon, Feb 6, 12:43 PM
Unknown Object (File)
Sat, Feb 4, 6:45 AM
Unknown Object (File)
Fri, Feb 3, 6:09 PM
Unknown Object (File)
Wed, Feb 1, 10:58 AM
Unknown Object (File)
Mon, Jan 23, 3:14 PM
Unknown Object (File)
Mon, Jan 23, 3:13 PM
Unknown Object (File)
Mon, Jan 23, 3:13 PM
Unknown Object (File)
Mon, Jan 23, 3:13 PM
Subscribers

Details

Summary

Ref T2222. These are pretty straightforward.

For these fields and a few others, the existing code shows the value for the "current/manual" diff (i.e., the diff selected in the diff selection table), not the "active" diff (i.e., the most recent diff attached to the revision). I'm going to drop that for now (always showing the most recent diff instead) and then reevaluate it once we're switched over. In 95% of cases these are the same, anyway.

Test Plan

Looked at fields; this diff changes nothing on its own.

Diff Detail

Repository
rP Phabricator
Branch
mfield1
Lint
Lint Passed
Unit
Tests Passed