Page MenuHomePhabricator

Add Branch and Arcanist Project CustomFields
ClosedPublic

Authored by epriestley on Feb 27 2014, 5:58 PM.
Tags
None
Referenced Files
F12834511: D8359.id19877.diff
Thu, Mar 28, 2:39 PM
Unknown Object (File)
Thu, Mar 14, 6:11 AM
Unknown Object (File)
Sun, Mar 10, 4:35 AM
Unknown Object (File)
Feb 8 2024, 11:23 PM
Unknown Object (File)
Jan 25 2024, 5:34 PM
Unknown Object (File)
Jan 25 2024, 5:34 PM
Unknown Object (File)
Jan 25 2024, 5:34 PM
Unknown Object (File)
Jan 24 2024, 9:17 PM
Subscribers

Details

Summary

Ref T2222. These are pretty straightforward.

For these fields and a few others, the existing code shows the value for the "current/manual" diff (i.e., the diff selected in the diff selection table), not the "active" diff (i.e., the most recent diff attached to the revision). I'm going to drop that for now (always showing the most recent diff instead) and then reevaluate it once we're switched over. In 95% of cases these are the same, anyway.

Test Plan

Looked at fields; this diff changes nothing on its own.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped