Move Differential to proper subscriptions
ClosedPublic
Actions

Authored by epriestley on Feb 12 2014, 12:18 AM.

Details

Reviewers

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential
T4415: Repair the other half of Project and Revision subscriptions

Commits

Restricted Diffusion Commit
rP8f9b7f419619: Move Differential to proper subscriptions

Summary

Ref T2222. Ref T4415. We're still writing Differential subscription stuff into this weird legacy differential_relationship table, which is like an edge table but extremely ancient.

Move it into a proper table.

I've removed withSubscriptions() from DifferentialRevisionQuery. It was weird, doesn't work consistently with other similar filters, and was only used by the API. Now it means "ccs", which is consistent with the ApplicationSearch UI and with Maniphest.

Test Plan

Without migrating, added and removed subscribers via various workflows. Queried for subscribers. Everything worked as expected.

Ran the migration, verified data survived.

Diff Detail

Repository

rP Phabricator

Branch

dxm1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/storage/DifferentialRevision.php:423	XHP16	TODO Comment
Advice	src/applications/differential/storage/DifferentialRevision.php:430	XHP16	TODO Comment
Advice	src/applications/differential/storage/DifferentialRevision.php:435	XHP16	TODO Comment

Unit

Tests Passed

Event Timeline

src/applications/differential/editor/DifferentialRevisionEditor.php
697	goodbye terrible code no one will miss you
src/applications/differential/storage/DifferentialRevision.php
236–237	I'll fix this, no longer accurate.