Paths

Table of Contentst

Differential D8202

Move Differential to proper subscriptions
ClosedPublic
Actions

Authored by epriestley on Feb 12 2014, 12:18 AM.

Tags

None

Referenced Files

	F13108752: D8202.diff
	Sun, Apr 28, 4:03 AM

	F13106763: D8202.id18561.diff
	Sat, Apr 27, 9:00 PM

	F13106762: D8202.id18557.diff
	Sat, Apr 27, 8:59 PM

	F13106761: D8202.id18556.diff
	Sat, Apr 27, 8:59 PM

	F13106760: D8202.id.diff
	Sat, Apr 27, 8:59 PM

	F13106758: D8202.diff
	Sat, Apr 27, 8:59 PM

	Unknown Object (File)
	Wed, Apr 24, 10:08 PM

	Unknown Object (File)
	Sat, Apr 20, 6:23 PM

Subscribers

Tokens

"Doubloon" token, awarded by btrahan.

Details

Reviewers

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential
T4415: Repair the other half of Project and Revision subscriptions

Commits

Restricted Diffusion Commit
rP8f9b7f419619: Move Differential to proper subscriptions

Summary

Ref T2222. Ref T4415. We're still writing Differential subscription stuff into this weird legacy differential_relationship table, which is like an edge table but extremely ancient.

Move it into a proper table.

I've removed withSubscriptions() from DifferentialRevisionQuery. It was weird, doesn't work consistently with other similar filters, and was only used by the API. Now it means "ccs", which is consistent with the ApplicationSearch UI and with Maniphest.

Test Plan

Without migrating, added and removed subscribers via various workflows. Queried for subscribers. Everything worked as expected.

Ran the migration, verified data survived.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

src/applications/differential/editor/DifferentialRevisionEditor.php
697	goodbye terrible code no one will miss you
src/applications/differential/storage/DifferentialRevision.php
236–237	I'll fix this, no longer accurate.

Remove comment about reading out of old table; we no longer do this.

resources/sql/autopatches/20140211.dx.3.migsubscriptions.sql
6–11	pretty cool

Closed by commit rP8f9b7f419619 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140211.dx.3.migsubscriptions.sql

10 lines

src/

__phutil_library_map__.php

1 line

applications/

differential/

conduit/

ConduitAPI_differential_query_Method.php

2 lines

editor/

DifferentialRevisionEditor.php

110 lines

query/

DifferentialRevisionQuery.php

93 lines

storage/

DifferentialRevision.php

61 lines

Diff 18561

resources/sql/autopatches/20140211.dx.3.migsubscriptions.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/differential/conduit/ConduitAPI_differential_query_Method.php

Loading...

src/applications/differential/editor/DifferentialRevisionEditor.php

Loading...

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...

src/applications/differential/storage/DifferentialRevision.php

Loading...