Fixes T4066.
add isActionDisabled() to DifferentialLandingStrategy, which also explains why it is so.
Make an appropriate pop-up in the controller.
Also make the whole UI "workflow", and convert createMenuItems() to createMenuItem() (Singular).
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4066: Hide the "Land to Hosted Repository" option unless the diff is accepted
- Commits
- Restricted Diffusion Commit
rPd0e30882a11f: Add Disabled mode to landing revision ui
Click "Land to..." button in all kinds of revisions.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed
Event Timeline
| src/applications/differential/controller/DifferentialRevisionLandController.php | ||
|---|---|---|
| 110–113 | we can maybe get rid of this test here, because it's the nth time we run it, but it's also the first time in this particular request. | |
| src/applications/differential/landing/DifferentialLandingStrategy.php | ||
| 13 | Did we had a reason for this to be pluralized? It made extracting the "disabled" state yucky. | |
| 37–38 | I don't like this pattern much, but it's short for an object with getDisabledStatus():bool and getDistabledReason():string. | |
Comment Actions
Seems reasonable to me.
| src/applications/differential/landing/DifferentialLandingStrategy.php | ||
|---|---|---|
| 13 | Given that you could implement multiple strategies to add multiple items, de-pluralizing it seems reasonable. | |